Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2898893002: Use SetSelection in ExecuteSelectToMark (Closed)

Created:
3 years, 7 months ago by tanvir
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SetSelection in ExecuteSelectToMark() ExecuteSelectToMark() is changed to use SetSelection() instead of SetSelectedRange(). BUG=721190 Review-Url: https://codereview.chromium.org/2898893002 Cr-Commit-Position: refs/heads/master@{#473866} Committed: https://chromium.googlesource.com/chromium/src/+/dc768d48cd58d1b0c0690e9ba866991088196996

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
tanvir
PTAL! Thanks
3 years, 7 months ago (2017-05-23 07:11:32 UTC) #4
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-23 08:36:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898893002/1
3 years, 7 months ago (2017-05-23 08:36:29 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 12:28:02 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dc768d48cd58d1b0c0690e9ba866...

Powered by Google App Engine
This is Rietveld 408576698