Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Issue 2898893002: Use SetSelection in ExecuteSelectToMark (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
index 847e5eefc2226e0f4a018ff85ae6fc4228edbf9d..336467f0fbcc8381a80e7ea74f5eade8a4666314 100644
--- a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
@@ -1789,9 +1789,11 @@ static bool ExecuteSelectToMark(LocalFrame& frame,
EphemeralRange selection = frame.GetEditor().SelectedRange();
if (mark.IsNull() || selection.IsNull())
return false;
- frame.Selection().SetSelectedRange(
- UnionEphemeralRanges(mark, selection), TextAffinity::kDownstream,
- SelectionDirectionalMode::kNonDirectional, FrameSelection::kCloseTyping);
+ frame.Selection().SetSelection(
+ SelectionInDOMTree::Builder()
+ .SetBaseAndExtent(UnionEphemeralRanges(mark, selection))
+ .Build(),
+ FrameSelection::kCloseTyping);
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698