Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2898733002: Allow WebrtcDummyVideoEncoder::RegisterEncodeCompleteCallback to take a nullptr. (Closed)

Created:
3 years, 7 months ago by brandtr-chromium
Modified:
3 years, 7 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, posciak+watch_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow WebrtcDummyVideoEncoder::RegisterEncodeCompleteCallback to take a nullptr. BUG=webrtc:7475 Review-Url: https://codereview.chromium.org/2898733002 Cr-Commit-Position: refs/heads/master@{#473819} Committed: https://chromium.googlesource.com/chromium/src/+/6a4269379e171f3748617361e26c6fcc40bf0270

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M remoting/protocol/webrtc_dummy_video_encoder.cc View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
brandtr-chromium
Hey Sergey, would you mind taking a look at this change? The DCHECK here currently ...
3 years, 7 months ago (2017-05-22 15:41:48 UTC) #6
Sergey Ulanov
lgtm
3 years, 7 months ago (2017-05-22 22:19:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898733002/1
3 years, 7 months ago (2017-05-23 05:38:09 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 05:41:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6a4269379e171f3748617361e26c...

Powered by Google App Engine
This is Rietveld 408576698