Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: remoting/protocol/webrtc_dummy_video_encoder.cc

Issue 2898733002: Allow WebrtcDummyVideoEncoder::RegisterEncodeCompleteCallback to take a nullptr. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/protocol/webrtc_dummy_video_encoder.cc
diff --git a/remoting/protocol/webrtc_dummy_video_encoder.cc b/remoting/protocol/webrtc_dummy_video_encoder.cc
index 52cc34e98400956623fc7985d81b7cfbabee8e72..be4d1352500aa989e9d6f7d46ef2c35b6cd07aba 100644
--- a/remoting/protocol/webrtc_dummy_video_encoder.cc
+++ b/remoting/protocol/webrtc_dummy_video_encoder.cc
@@ -53,7 +53,6 @@ int32_t WebrtcDummyVideoEncoder::InitEncode(
int32_t WebrtcDummyVideoEncoder::RegisterEncodeCompleteCallback(
webrtc::EncodedImageCallback* callback) {
- DCHECK(callback);
base::AutoLock lock(lock_);
encoded_callback_ = callback;
return WEBRTC_VIDEO_CODEC_OK;
@@ -163,6 +162,7 @@ webrtc::EncodedImageCallback::Result WebrtcDummyVideoEncoder::SendEncodedFrame(
header.fragmentationPlType[0] = 0;
header.fragmentationTimeDiff[0] = 0;
+ DCHECK(encoded_callback_);
return encoded_callback_->OnEncodedImage(encoded_image, &codec_specific_info,
&header);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698