Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 2898613002: Revert of Support finer grained font weights on Mac. (Closed)

Created:
3 years, 7 months ago by tapted
Modified:
3 years, 7 months ago
CC:
chromium-reviews, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Support finer grained font weights on Mac. (patchset #6 id:240001 of https://codereview.chromium.org/2869803005/ ) Reason for revert: Need to test 10.11 again. failures in the build cycle at https://luci-milo.appspot.com/buildbot/chromium.mac/Mac10.11%20Tests/12666 Original issue's description: > Support finer grained font weights on Mac. > > We want to explore a MEDIUM weight for button text under Harmony. This > is consistent with MD and helps compensate for buttons not using solid > black for the font color. > > The San Francisco font in 10.11 and 10.12 has good support for finer > grained weights and is the font Chrome UI is mostly concerned with, so > focus testing on that but survey expectations for all supported OS > versions. > > BUG=691891 > > Review-Url: https://codereview.chromium.org/2869803005 > Cr-Commit-Position: refs/heads/master@{#473457} > Committed: https://chromium.googlesource.com/chromium/src/+/bc62dfeaf37c83a79f393cb536fb22b39ea87097 TBR=asvitkine@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=691891 Review-Url: https://codereview.chromium.org/2898613002 Cr-Commit-Position: refs/heads/master@{#473460} Committed: https://chromium.googlesource.com/chromium/src/+/cb23bc6b0dae9c82bb9845b4ea367d72e8c2edaf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -370 lines) Patch
M ui/gfx/platform_font_mac.mm View 4 chunks +19 lines, -142 lines 0 comments Download
M ui/gfx/platform_font_mac_unittest.mm View 3 chunks +10 lines, -192 lines 0 comments Download
M ui/views/examples/example_combobox_model.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/examples/example_combobox_model.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/examples/text_example.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/examples/text_example.cc View 6 chunks +6 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tapted
Created Revert of Support finer grained font weights on Mac.
3 years, 7 months ago (2017-05-21 04:38:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898613002/1
3 years, 7 months ago (2017-05-21 04:38:14 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-21 04:38:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cb23bc6b0dae9c82bb9845b4ea36...

Powered by Google App Engine
This is Rietveld 408576698