Support finer grained font weights on Mac.

Support finer grained font weights on Mac.

We want to explore a MEDIUM weight for button text under Harmony. This
is consistent with MD and helps compensate for buttons not using solid
black for the font color.

The San Francisco font in 10.12 has good support for finer
grained weights and is the font Chrome UI is mostly concerned with, so
focus testing on that but survey expectations for all supported OS
versions.

BUG=691891
Review-Url: https://codereview.chromium.org/2869803005
Cr-Commit-Position: refs/heads/master@{#473490}
Committed: https://chromium.googlesource.com/chromium/src/+/124eb0b5af215ce2df373be6552228d79090256e

[tapted, 2017-05-09 08:14:45]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 08:15:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 09:15:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 09:15:27]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tapted, 2017-05-10 06:05:36]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 06:06:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-05-10 06:22:31]

The CQ bit was unchecked by tapted@chromium.org

[tapted, 2017-05-10 07:06:26]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 07:07:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 07:45:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 07:45:45]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-05-10 08:38:40]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 08:39:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 08:52:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 08:52:39]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tapted, 2017-05-10 09:42:05]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 09:42:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-05-10 09:46:09]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 09:46:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 10:00:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 10:00:58]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tapted, 2017-05-11 01:00:53]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-11 01:03:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 01:40:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-11 01:40:57]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-05-11 05:01:53]

Patchset #1 (id:1) has been deleted

[tapted, 2017-05-11 05:02:06]

Patchset #3 (id:60001) has been deleted

[tapted, 2017-05-11 05:02:16]

Patchset #3 (id:80001) has been deleted

[tapted, 2017-05-11 05:02:27]

Patchset #2 (id:40001) has been deleted

[tapted, 2017-05-11 05:02:39]

Patchset #2 (id:100001) has been deleted

[tapted, 2017-05-11 05:02:50]

Patchset #2 (id:120001) has been deleted

[tapted, 2017-05-11 05:02:59]

Patchset #2 (id:140001) has been deleted

[tapted, 2017-05-18 06:56:09]

Description was changed from

==========
Support finer grained font weights on Mac.

cl format


typo


cl format


GetFontWeightFromNSFont

BUG=
==========

to

==========
Support finer grained font weights on Mac.

We want to explore a MEDIUM weight for button text under Harmony. This
is consistent with MD and helps compensate for buttons not using solid
black for the font color.

The San Francisco font in 10.11 and 10.12 has good support for finer
grained weights and is the font Chrome UI is mostly concerned with, so
focus testing on that.

BUG=691891
==========

[tapted, 2017-05-18 06:57:00]

Description was changed from

==========
Support finer grained font weights on Mac.

We want to explore a MEDIUM weight for button text under Harmony. This
is consistent with MD and helps compensate for buttons not using solid
black for the font color.

The San Francisco font in 10.11 and 10.12 has good support for finer
grained weights and is the font Chrome UI is mostly concerned with, so
focus testing on that.

BUG=691891
==========

to

==========
Support finer grained font weights on Mac.

We want to explore a MEDIUM weight for button text under Harmony. This
is consistent with MD and helps compensate for buttons not using solid
black for the font color.

The San Francisco font in 10.11 and 10.12 has good support for finer
grained weights and is the font Chrome UI is mostly concerned with, so
focus testing on that but survey expectations for all supported OS
versions.

BUG=691891
==========

[tapted, 2017-05-18 10:02:44]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 10:03:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 11:15:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 11:15:45]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[tapted, 2017-05-18 11:50:29]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 11:51:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 12:22:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 12:22:45]

Dry run: This issue passed the CQ dry run.

[tapted, 2017-05-19 07:15:19]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 07:16:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-05-19 07:18:11]

tapted@chromium.org changed reviewers:
+ asvitkine@chromium.org

[tapted, 2017-05-19 07:18:12]

Hi Alexei, please take a look.. Mac font APIs seem to be a bit rubbish for this.
Ater a ton of experimentation, this seems to be a viable approach.

[commit-bot: I haz the power, 2017-05-19 07:53:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 07:53:49]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2017-05-19 20:31:17]

lgtm

https://codereview.chromium.org/2869803005/diff/220001/ui/gfx/platform_font_m...
File ui/gfx/platform_font_mac.mm (right):

https://codereview.chromium.org/2869803005/diff/220001/ui/gfx/platform_font_m...
ui/gfx/platform_font_mac.mm:217: // in
CTFont{Regular,Medium,Demi,Emphasized,Heavy,Black}Usage. Attempting to
Nit: in fits on previous line?

https://codereview.chromium.org/2869803005/diff/220001/ui/gfx/platform_font_m...
File ui/gfx/platform_font_mac_unittest.mm (right):

https://codereview.chromium.org/2869803005/diff/220001/ui/gfx/platform_font_m...
ui/gfx/platform_font_mac_unittest.mm:143: // font reveal themselves somehow.
Only tested on 10.11+.
geez :(

[tapted, 2017-05-21 02:47:54]

https://codereview.chromium.org/2869803005/diff/220001/ui/gfx/platform_font_m...
File ui/gfx/platform_font_mac.mm (right):

https://codereview.chromium.org/2869803005/diff/220001/ui/gfx/platform_font_m...
ui/gfx/platform_font_mac.mm:217: // in
CTFont{Regular,Medium,Demi,Emphasized,Heavy,Black}Usage. Attempting to
On 2017/05/19 20:31:17, Alexei Svitkine (slow) wrote:
> Nit: in fits on previous line?

Done.

https://codereview.chromium.org/2869803005/diff/220001/ui/gfx/platform_font_m...
File ui/gfx/platform_font_mac_unittest.mm (right):

https://codereview.chromium.org/2869803005/diff/220001/ui/gfx/platform_font_m...
ui/gfx/platform_font_mac_unittest.mm:143: // font reveal themselves somehow.
Only tested on 10.11+.
On 2017/05/19 20:31:17, Alexei Svitkine (slow) wrote:
> geez :(

yah :/. I'll file a rdar for this - the repro case is pretty simple so it may
even be fixed. (Although the response may also be something like "ui fonts don't
support this").

[tapted, 2017-05-21 02:47:59]

The CQ bit was checked by tapted@chromium.org

[tapted, 2017-05-21 02:48:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2869803005/#ps240001
(title: "respond to comments")

[commit-bot: I haz the power, 2017-05-21 02:48:09]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-21 03:10:18]

CQ is committing da patch.

Bot data: {"patchset_id": 240001, "attempt_start_ts": 1495334879745270,
"parent_rev": "3cb12d3b5ec5f5b0b4cc850e4cedefdad40f925f", "commit_rev":
"bc62dfeaf37c83a79f393cb536fb22b39ea87097"}

[commit-bot: I haz the power, 2017-05-21 03:10:30]

Description was changed from

==========
Support finer grained font weights on Mac.

We want to explore a MEDIUM weight for button text under Harmony. This
is consistent with MD and helps compensate for buttons not using solid
black for the font color.

The San Francisco font in 10.11 and 10.12 has good support for finer
grained weights and is the font Chrome UI is mostly concerned with, so
focus testing on that but survey expectations for all supported OS
versions.

BUG=691891
==========

to

==========
Support finer grained font weights on Mac.

We want to explore a MEDIUM weight for button text under Harmony. This
is consistent with MD and helps compensate for buttons not using solid
black for the font color.

The San Francisco font in 10.11 and 10.12 has good support for finer
grained weights and is the font Chrome UI is mostly concerned with, so
focus testing on that but survey expectations for all supported OS
versions.

BUG=691891

Review-Url: https://codereview.chromium.org/2869803005
Cr-Commit-Position: refs/heads/master@{#473457}
Committed:
https://chromium.googlesource.com/chromium/src/+/bc62dfeaf37c83a79f393cb536fb...
==========

[commit-bot: I haz the power, 2017-05-21 03:10:32]

Committed patchset #6 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/bc62dfeaf37c83a79f393cb536fb...

[findit-for-me, 2017-05-21 03:58:43]

Findit (https://goo.gl/kROfz5) identified this CL at revision 473457 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[tapted, 2017-05-21 04:38:09]

A revert of this CL (patchset #6 id:240001) has been created in
https://codereview.chromium.org/2898613002/ by tapted@chromium.org.

The reason for reverting is: Need to test 10.11 again.

failures in the build cycle at
https://luci-milo.appspot.com/buildbot/chromium.mac/Mac10.11%20Tests/12666.

[tapted, 2017-05-22 00:12:03]

Description was changed from

==========
Support finer grained font weights on Mac.

We want to explore a MEDIUM weight for button text under Harmony. This
is consistent with MD and helps compensate for buttons not using solid
black for the font color.

The San Francisco font in 10.11 and 10.12 has good support for finer
grained weights and is the font Chrome UI is mostly concerned with, so
focus testing on that but survey expectations for all supported OS
versions.

BUG=691891

Review-Url: https://codereview.chromium.org/2869803005
Cr-Commit-Position: refs/heads/master@{#473457}
Committed:
https://chromium.googlesource.com/chromium/src/+/bc62dfeaf37c83a79f393cb536fb...
==========

to

==========
Support finer grained font weights on Mac.

We want to explore a MEDIUM weight for button text under Harmony. This
is consistent with MD and helps compensate for buttons not using solid
black for the font color.

The San Francisco font in 10.11 and 10.12 has good support for finer
grained weights and is the font Chrome UI is mostly concerned with, so
focus testing on that but survey expectations for all supported OS
versions.

BUG=691891

Review-Url: https://codereview.chromium.org/2869803005
Cr-Commit-Position: refs/heads/master@{#473457}
Committed:
https://chromium.googlesource.com/chromium/src/+/bc62dfeaf37c83a79f393cb536fb...
==========

[tapted, 2017-05-22 00:13:50]

Description was changed from

==========
Support finer grained font weights on Mac.

We want to explore a MEDIUM weight for button text under Harmony. This
is consistent with MD and helps compensate for buttons not using solid
black for the font color.

The San Francisco font in 10.11 and 10.12 has good support for finer
grained weights and is the font Chrome UI is mostly concerned with, so
focus testing on that but survey expectations for all supported OS
versions.

BUG=691891

Review-Url: https://codereview.chromium.org/2869803005
Cr-Commit-Position: refs/heads/master@{#473457}
Committed:
https://chromium.googlesource.com/chromium/src/+/bc62dfeaf37c83a79f393cb536fb...
==========

to

==========
Support finer grained font weights on Mac.

We want to explore a MEDIUM weight for button text under Harmony. This
is consistent with MD and helps compensate for buttons not using solid
black for the font color.

The San Francisco font in 10.12 has good support for finer
grained weights and is the font Chrome UI is mostly concerned with, so
focus testing on that but survey expectations for all supported OS
versions.

BUG=691891
==========

[tapted, 2017-05-22 01:10:21]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 01:10:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tapted, 2017-05-22 01:16:37]

https://codereview.chromium.org/2869803005/diff/260001/ui/gfx/platform_font_m...
File ui/gfx/platform_font_mac_unittest.mm (right):

https://codereview.chromium.org/2869803005/diff/260001/ui/gfx/platform_font_m...
ui/gfx/platform_font_mac_unittest.mm:270: // The fine-grained font weights on
10.11 are incomplete.
Naive of me to think that there was even one OS version where Apple didn't mess
around with their fonts :/.. 10.11 is San Francisco but a "different" San
Francisco, which is missing some weights. It's consistent otherwise though.

The other OSes were happy in the waterfall

https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/41470
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/18212
https://build.chromium.org/p/chromium.mac/builders/Mac10.12%20Tests/builds/730

[tapted, 2017-05-22 01:22:55]

The CQ bit was checked by tapted@chromium.org

[tapted, 2017-05-22 01:22:55]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2869803005/#ps280001
(title: "self review - tested normal twice")

[commit-bot: I haz the power, 2017-05-22 01:23:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 01:54:17]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1495416175133230,
"parent_rev": "c3636c2887c896911de99d208889b2582cf5e56b", "commit_rev":
"124eb0b5af215ce2df373be6552228d79090256e"}

[commit-bot: I haz the power, 2017-05-22 01:54:29]

Description was changed from

==========
Support finer grained font weights on Mac.

We want to explore a MEDIUM weight for button text under Harmony. This
is consistent with MD and helps compensate for buttons not using solid
black for the font color.

The San Francisco font in 10.12 has good support for finer
grained weights and is the font Chrome UI is mostly concerned with, so
focus testing on that but survey expectations for all supported OS
versions.

BUG=691891
==========

to

==========
Support finer grained font weights on Mac.

We want to explore a MEDIUM weight for button text under Harmony. This
is consistent with MD and helps compensate for buttons not using solid
black for the font color.

The San Francisco font in 10.12 has good support for finer
grained weights and is the font Chrome UI is mostly concerned with, so
focus testing on that but survey expectations for all supported OS
versions.

BUG=691891

Review-Url: https://codereview.chromium.org/2869803005
Cr-Commit-Position: refs/heads/master@{#473490}
Committed:
https://chromium.googlesource.com/chromium/src/+/124eb0b5af215ce2df373be65522...
==========

[commit-bot: I haz the power, 2017-05-22 01:54:31]

Committed patchset #8 (id:280001) as
https://chromium.googlesource.com/chromium/src/+/124eb0b5af215ce2df373be65522...