third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc - Issue 2898413002: [LayoutNG] Add box fragments to line boxes when needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc

Issue 2898413002: [LayoutNG] Add box fragments to line boxes when needed (Closed)

Patch Set: x64 build fix Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.h ('k') | third_party/WebKit/Source/core/layout/ng/ng_fragment.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc b/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc

index 8c1b2b5bef7ca0769620323302390e4ca239acf6..b7da84858ebe5da66fbb70122fce95772f719979 100644

--- a/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc

+++ b/third_party/WebKit/Source/core/layout/ng/inline/ng_line_box_fragment_builder.cc

@@ -14,7 +14,15 @@

namespace blink {

NGLineBoxFragmentBuilder::NGLineBoxFragmentBuilder(NGInlineNode* node)

- : direction_(TextDirection::kLtr), node_(node) {}

+ : writing_mode_(kHorizontalTopBottom),

+ direction_(TextDirection::kLtr),

+ node_(node) {}

+NGLineBoxFragmentBuilder& NGLineBoxFragmentBuilder::SetWritingMode(

+ NGWritingMode writing_mode) {

+ writing_mode_ = writing_mode;

+ return *this;

NGLineBoxFragmentBuilder& NGLineBoxFragmentBuilder::SetDirection(

TextDirection direction) {