Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2898273002:
Move Voice Interaction shortcut to accelerator_controller.cc (Closed)
|
Created:
3 years, 7 months ago by yueli Modified:
3 years, 7 months ago CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, sadrul, yusukes+watch_chromium.org, derat+watch_chromium.org, tfarina, hidehiko+watch_chromium.org, oshima+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, kalyank, davemoore+watch_chromium.org, Matt Giuca Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove Voice Interaction shortcut to accelerator_controller.cc
- Move voice interaction shortcut to accelerator controller.
- The temporary meta layer shortcut will remain and will be removed
later.
- Prioritize the container startup if the shortcut pressed before ARC
boot.
BUG=b/37953242
Review-Url: https://codereview.chromium.org/2898273002
Cr-Commit-Position: refs/heads/master@{#474776}
Committed: https://chromium.googlesource.com/chromium/src/+/29b240ae17270e355c2a0d09e0e026be0ee9da40
Patch Set 1 #
Total comments: 17
Patch Set 2 : Refactor #
Total comments: 6
Patch Set 3 : Renaming and Cleanup #Patch Set 4 : Rebase #Patch Set 5 : Rebase again #Patch Set 6 : Move Voice Interaction shortcut to accelerator_controller.cc #Messages
Total messages: 50 (41 generated)
Description was changed from ========== Move Voice Interaction shortcut to accelerator_controller.cc - Move voice interaction shortcut to accelerator controller. - The temporary meta layer shortcut will remain and will be removed later. - Prioritize the container startup if the shortcut pressed before ARC boot. BUG=b/37953242 ========== to ========== Move Voice Interaction shortcut to accelerator_controller.cc - Move voice interaction shortcut to accelerator controller. - The temporary meta layer shortcut will remain and will be removed later. - Prioritize the container startup if the shortcut pressed before ARC boot. BUG=b/37953242 ==========
updowndota@chromium.org changed reviewers: + sky@chromium.org, xiaohuic@chromium.org, yusukes@chromium.org
PTAL
The CQ bit was checked by yusukes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
https://codereview.chromium.org/2898273002/diff/1/ash/accelerators/accelerato... File ash/accelerators/accelerator_table.cc (right): https://codereview.chromium.org/2898273002/diff/1/ash/accelerators/accelerato... ash/accelerators/accelerator_table.cc:165: {true, ui::VKEY_A, ui::EF_COMMAND_DOWN, START_VOICE_INTERACTION}, Shouldn't we also update chrome/browser/resources/chromeos/keyboard_overlay_data.js to add the accelerator to the Ctrl+Alt+/ help? (please ask afakhry@ if you're not sure.) https://codereview.chromium.org/2898273002/diff/1/ash/accelerators/accelerato... ash/accelerators/accelerator_table.cc:166: // Temporary shortcut added for UX/PM exploration. Then, // TODO(ldap): Remove the accelerator. ? https://codereview.chromium.org/2898273002/diff/1/chrome/browser/chromeos/arc... File chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc (right): https://codereview.chromium.org/2898273002/diff/1/chrome/browser/chromeos/arc... chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:16: #include "chrome/browser/ui/app_list/arc/arc_app_utils.h" components/arc/arc_util.h https://codereview.chromium.org/2898273002/diff/1/chrome/browser/chromeos/arc... chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:174: arc::PrioritizeArcContainerStartup(); If the user starts an ARC app (e.g. Play Store) before the container is ready, ash shows a spinner icon to notify the user that the app is being launched. Shouldn't we do the same for this feature? Calling the prioritization function is no-op from the user's perspective. https://codereview.chromium.org/2898273002/diff/1/chrome/browser/chromeos/arc... File chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h (right): https://codereview.chromium.org/2898273002/diff/1/chrome/browser/chromeos/arc... chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h:51: void StartVoiceInteractionSession(); Function comment please. This is public. https://codereview.chromium.org/2898273002/diff/1/chrome/browser/ui/app_list/... File chrome/browser/ui/app_list/arc/arc_app_utils.h (right): https://codereview.chromium.org/2898273002/diff/1/chrome/browser/ui/app_list/... chrome/browser/ui/app_list/arc/arc_app_utils.h:97: // Set CPU restriction for ARC to prioritize the container startup. Sets https://codereview.chromium.org/2898273002/diff/1/chrome/browser/ui/app_list/... chrome/browser/ui/app_list/arc/arc_app_utils.h:98: void PrioritizeArcContainerStartup(); Could you move it to components/arc/arc_util.h? https://codereview.chromium.org/2898273002/diff/1/chrome/browser/ui/ash/app_l... File chrome/browser/ui/ash/app_list/app_list_presenter_service.cc (right): https://codereview.chromium.org/2898273002/diff/1/chrome/browser/ui/ash/app_l... chrome/browser/ui/ash/app_list/app_list_presenter_service.cc:10: #include "chrome/browser/chromeos/arc/arc_util.h" What is this for?
https://codereview.chromium.org/2898273002/diff/1/ash/accelerators/accelerato... File ash/accelerators/accelerator_table.cc (right): https://codereview.chromium.org/2898273002/diff/1/ash/accelerators/accelerato... ash/accelerators/accelerator_table.cc:165: {true, ui::VKEY_A, ui::EF_COMMAND_DOWN, START_VOICE_INTERACTION}, On 2017/05/23 19:41:51, Yusuke Sato wrote: > Shouldn't we also update > chrome/browser/resources/chromeos/keyboard_overlay_data.js to add the > accelerator to the Ctrl+Alt+/ help? (please ask afakhry@ if you're not sure.) > Currently such accelerators should only be shown on certain devices that have arc enabled. Is there any way I can make this optional? Otherwise I think we don't want to add it into the help page for now. https://codereview.chromium.org/2898273002/diff/1/ash/accelerators/accelerato... ash/accelerators/accelerator_table.cc:166: // Temporary shortcut added for UX/PM exploration. On 2017/05/23 19:41:51, Yusuke Sato wrote: > Then, > // TODO(ldap): Remove the accelerator. > ? Done. https://codereview.chromium.org/2898273002/diff/1/chrome/browser/chromeos/arc... File chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc (right): https://codereview.chromium.org/2898273002/diff/1/chrome/browser/chromeos/arc... chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:16: #include "chrome/browser/ui/app_list/arc/arc_app_utils.h" On 2017/05/23 19:41:52, Yusuke Sato wrote: > components/arc/arc_util.h Done. https://codereview.chromium.org/2898273002/diff/1/chrome/browser/chromeos/arc... chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:174: arc::PrioritizeArcContainerStartup(); On 2017/05/23 19:41:51, Yusuke Sato wrote: > If the user starts an ARC app (e.g. Play Store) before the container is ready, > ash shows a spinner icon to notify the user that the app is being launched. > Shouldn't we do the same for this feature? Calling the prioritization function > is no-op from the user's perspective. Currently we have no place to show such spinner since we don't even have an icon for voice interaction on the shelf. And the UX side also have not come up with a solution for this currently. https://codereview.chromium.org/2898273002/diff/1/chrome/browser/chromeos/arc... File chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h (right): https://codereview.chromium.org/2898273002/diff/1/chrome/browser/chromeos/arc... chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.h:51: void StartVoiceInteractionSession(); On 2017/05/23 19:41:52, Yusuke Sato wrote: > Function comment please. This is public. Done. https://codereview.chromium.org/2898273002/diff/1/chrome/browser/ui/app_list/... File chrome/browser/ui/app_list/arc/arc_app_utils.h (right): https://codereview.chromium.org/2898273002/diff/1/chrome/browser/ui/app_list/... chrome/browser/ui/app_list/arc/arc_app_utils.h:97: // Set CPU restriction for ARC to prioritize the container startup. On 2017/05/23 19:41:52, Yusuke Sato wrote: > Sets Done. https://codereview.chromium.org/2898273002/diff/1/chrome/browser/ui/app_list/... chrome/browser/ui/app_list/arc/arc_app_utils.h:98: void PrioritizeArcContainerStartup(); On 2017/05/23 19:41:52, Yusuke Sato wrote: > Could you move it to components/arc/arc_util.h? Done. https://codereview.chromium.org/2898273002/diff/1/chrome/browser/ui/ash/app_l... File chrome/browser/ui/ash/app_list/app_list_presenter_service.cc (right): https://codereview.chromium.org/2898273002/diff/1/chrome/browser/ui/ash/app_l... chrome/browser/ui/ash/app_list/app_list_presenter_service.cc:10: #include "chrome/browser/chromeos/arc/arc_util.h" On 2017/05/23 19:41:52, Yusuke Sato wrote: > What is this for? removed.
The CQ bit was checked by yusukes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
components/arc/ and c/b/c/arc/ lgtm https://codereview.chromium.org/2898273002/diff/1/chrome/browser/chromeos/arc... File chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc (right): https://codereview.chromium.org/2898273002/diff/1/chrome/browser/chromeos/arc... chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:174: arc::PrioritizeArcContainerStartup(); On 2017/05/23 22:59:56, yueli wrote: > On 2017/05/23 19:41:51, Yusuke Sato wrote: > > If the user starts an ARC app (e.g. Play Store) before the container is ready, > > ash shows a spinner icon to notify the user that the app is being launched. > > Shouldn't we do the same for this feature? Calling the prioritization function > > is no-op from the user's perspective. > > Currently we have no place to show such spinner since we don't even have an icon > for voice interaction on the shelf. And the UX side also have not come up with a > solution for this currently. Ok, but please make sure to inform UX team of the problem. The current behavior is probably not optimal for users. For now, can you add a TODO? https://codereview.chromium.org/2898273002/diff/20001/chrome/browser/ui/app_l... File chrome/browser/ui/app_list/arc/arc_app_utils.cc (right): https://codereview.chromium.org/2898273002/diff/20001/chrome/browser/ui/app_l... chrome/browser/ui/app_list/arc/arc_app_utils.cc:24: #include "chromeos/dbus/dbus_thread_manager.h" delete https://codereview.chromium.org/2898273002/diff/20001/chrome/browser/ui/app_l... chrome/browser/ui/app_list/arc/arc_app_utils.cc:25: #include "chromeos/dbus/session_manager_client.h" delete https://codereview.chromium.org/2898273002/diff/20001/components/arc/arc_util.h File components/arc/arc_util.h (right): https://codereview.chromium.org/2898273002/diff/20001/components/arc/arc_util... components/arc/arc_util.h:70: void PrioritizeArcContainerStartup(); Actually this is not only for startup. The prioritization is effective even after the container finishes booting. So void PrioritizeArcContainer(); would be better. Please update the function comment too.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...) win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)
On 2017/05/23 23:11:56, Yusuke Sato wrote: > components/arc/ and c/b/c/arc/ lgtm > > https://codereview.chromium.org/2898273002/diff/1/chrome/browser/chromeos/arc... > File > chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc > (right): > > https://codereview.chromium.org/2898273002/diff/1/chrome/browser/chromeos/arc... > chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc:174: > arc::PrioritizeArcContainerStartup(); > On 2017/05/23 22:59:56, yueli wrote: > > On 2017/05/23 19:41:51, Yusuke Sato wrote: > > > If the user starts an ARC app (e.g. Play Store) before the container is > ready, > > > ash shows a spinner icon to notify the user that the app is being launched. > > > Shouldn't we do the same for this feature? Calling the prioritization > function > > > is no-op from the user's perspective. > > > > Currently we have no place to show such spinner since we don't even have an > icon > > for voice interaction on the shelf. And the UX side also have not come up with > a > > solution for this currently. > > Ok, but please make sure to inform UX team of the problem. The current behavior > is probably not optimal for users. > > For now, can you add a TODO? > > https://codereview.chromium.org/2898273002/diff/20001/chrome/browser/ui/app_l... > File chrome/browser/ui/app_list/arc/arc_app_utils.cc (right): > > https://codereview.chromium.org/2898273002/diff/20001/chrome/browser/ui/app_l... > chrome/browser/ui/app_list/arc/arc_app_utils.cc:24: #include > "chromeos/dbus/dbus_thread_manager.h" > delete > > https://codereview.chromium.org/2898273002/diff/20001/chrome/browser/ui/app_l... > chrome/browser/ui/app_list/arc/arc_app_utils.cc:25: #include > "chromeos/dbus/session_manager_client.h" > delete > > https://codereview.chromium.org/2898273002/diff/20001/components/arc/arc_util.h > File components/arc/arc_util.h (right): > > https://codereview.chromium.org/2898273002/diff/20001/components/arc/arc_util... > components/arc/arc_util.h:70: void PrioritizeArcContainerStartup(); > Actually this is not only for startup. The prioritization is effective even > after the container finishes booting. So > > void PrioritizeArcContainer(); > > would be better. Please update the function comment too. Can you also rebase your change? Your doesn't cleanly apply to tot Chromium.
https://codereview.chromium.org/2898273002/diff/20001/chrome/browser/ui/app_l... File chrome/browser/ui/app_list/arc/arc_app_utils.cc (right): https://codereview.chromium.org/2898273002/diff/20001/chrome/browser/ui/app_l... chrome/browser/ui/app_list/arc/arc_app_utils.cc:24: #include "chromeos/dbus/dbus_thread_manager.h" On 2017/05/23 23:11:56, Yusuke Sato wrote: > delete Done. https://codereview.chromium.org/2898273002/diff/20001/chrome/browser/ui/app_l... chrome/browser/ui/app_list/arc/arc_app_utils.cc:25: #include "chromeos/dbus/session_manager_client.h" On 2017/05/23 23:11:56, Yusuke Sato wrote: > delete Done. https://codereview.chromium.org/2898273002/diff/20001/components/arc/arc_util.h File components/arc/arc_util.h (right): https://codereview.chromium.org/2898273002/diff/20001/components/arc/arc_util... components/arc/arc_util.h:70: void PrioritizeArcContainerStartup(); On 2017/05/23 23:11:56, Yusuke Sato wrote: > Actually this is not only for startup. The prioritization is effective even > after the container finishes booting. So > > void PrioritizeArcContainer(); > > would be better. Please update the function comment too. > Done.
LGTM
The CQ bit was checked by yusukes@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by updowndota@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by updowndota@chromium.org
The CQ bit was checked by updowndota@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by updowndota@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by updowndota@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by updowndota@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by updowndota@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by updowndota@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yusukes@chromium.org, sky@chromium.org Link to the patchset: https://codereview.chromium.org/2898273002/#ps100001 (title: "Move Voice Interaction shortcut to accelerator_controller.cc")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495743178793090,
"parent_rev": "3f84b89622f729ebffe8955fa06d59501d9172d2", "commit_rev":
"29b240ae17270e355c2a0d09e0e026be0ee9da40"}
Message was sent while issue was closed.
Description was changed from ========== Move Voice Interaction shortcut to accelerator_controller.cc - Move voice interaction shortcut to accelerator controller. - The temporary meta layer shortcut will remain and will be removed later. - Prioritize the container startup if the shortcut pressed before ARC boot. BUG=b/37953242 ========== to ========== Move Voice Interaction shortcut to accelerator_controller.cc - Move voice interaction shortcut to accelerator controller. - The temporary meta layer shortcut will remain and will be removed later. - Prioritize the container startup if the shortcut pressed before ARC boot. BUG=b/37953242 Review-Url: https://codereview.chromium.org/2898273002 Cr-Commit-Position: refs/heads/master@{#474776} Committed: https://chromium.googlesource.com/chromium/src/+/29b240ae17270e355c2a0d09e0e0... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/29b240ae17270e355c2a0d09e0e0... |
