Move Voice Interaction shortcut to accelerator_controller.cc

ash/accelerators/accelerator_table.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/accelerators/accelerator_table.h"
 
 #include "ash/strings/grit/ash_strings.h"
 #include "base/macros.h"
 
 namespace ash {
@@ skipping 143 matching lines @@
     {true, ui::VKEY_OEM_PLUS, ui::EF_SHIFT_DOWN | ui::EF_ALT_DOWN,
      WINDOW_POSITION_CENTER},
     {true, ui::VKEY_BROWSER_FORWARD, ui::EF_CONTROL_DOWN, FOCUS_NEXT_PANE},
     {true, ui::VKEY_BROWSER_BACK, ui::EF_CONTROL_DOWN, FOCUS_PREVIOUS_PANE},
 
     // Media Player shortcuts.
     {true, ui::VKEY_MEDIA_NEXT_TRACK, ui::EF_NONE, MEDIA_NEXT_TRACK},
     {true, ui::VKEY_MEDIA_PLAY_PAUSE, ui::EF_NONE, MEDIA_PLAY_PAUSE},
     {true, ui::VKEY_MEDIA_PREV_TRACK, ui::EF_NONE, MEDIA_PREV_TRACK},
 
+    // Voice Interaction shortcuts.
+    {true, ui::VKEY_A, ui::EF_COMMAND_DOWN, START_VOICE_INTERACTION},

[Yusuke Sato, 2017/05/23 19:41:51]

Shouldn't we also update
chrome/browser/resources/chromeos/keyboard_overlay_data.js to add the
accelerator to the Ctrl+Alt+/ help? (please ask afakhry@ if you're not sure.)

[yueli, 2017/05/23 22:59:56]

Currently such accelerators should only be shown on certain devices that have
arc enabled. Is there any way I can make this optional? Otherwise I think we
don't want to add it into the help page for now.

+    // Temporary shortcut added for UX/PM exploration.

[Yusuke Sato, 2017/05/23 19:41:51]

Then,
 // TODO(ldap): Remove the accelerator.
?

[yueli, 2017/05/23 22:59:56]

Done.

+    {true, ui::VKEY_SPACE, ui::EF_COMMAND_DOWN, START_VOICE_INTERACTION},
+
     // Debugging shortcuts that need to be available to end-users in
     // release builds.
     {true, ui::VKEY_U, kDebugModifier, PRINT_UI_HIERARCHIES},
 
     // TODO(yusukes): Handle VKEY_MEDIA_STOP, and
     // VKEY_MEDIA_LAUNCH_MAIL.
 };
 
 const size_t kAcceleratorDataLength = arraysize(kAcceleratorData);
 
@@ skipping 328 matching lines @@
     TOGGLE_SPOKEN_FEEDBACK,
     TOGGLE_WIFI,
     VOLUME_DOWN,
     VOLUME_MUTE,
     VOLUME_UP,
 };
 
 const size_t kActionsKeepingMenuOpenLength = arraysize(kActionsKeepingMenuOpen);
 
 }  // namespace ash