Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issue 2898243002: [Android] Add OverviewListLayout to main CoordinatorLayout (Closed)

Created:
3 years, 7 months ago by Theresa
Modified:
3 years, 7 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org, mdjones
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add OverviewListLayout to main CoordinatorLayout Rather than adding the accessibility tab switcher layout to R.id.content, add it to a FrameLayout in the main CoordinatorLayout so that the Chrome Home bottom sheet can be drawn on top of it. BUG=724700 Review-Url: https://codereview.chromium.org/2898243002 Cr-Commit-Position: refs/heads/master@{#474417} Committed: https://chromium.googlesource.com/chromium/src/+/7dfe6af12787999c6f219ae1df78d44608d5dc45

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/android/java/res/layout/main.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java View 1 chunk +3 lines, -4 lines 2 comments Download

Messages

Total messages: 14 (8 generated)
Theresa
ptal
3 years, 7 months ago (2017-05-23 17:33:04 UTC) #3
Theresa
24-hour ping. I'd love to get this small CL landed by EOD since I'm OOO ...
3 years, 7 months ago (2017-05-24 18:46:34 UTC) #7
David Trainor- moved to gerrit
lgtm % todo nit. Sorry for the delay! https://codereview.chromium.org/2898243002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java File chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java (right): https://codereview.chromium.org/2898243002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java#newcode60 chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java:60: ((ViewGroup) ...
3 years, 7 months ago (2017-05-24 18:58:23 UTC) #8
Theresa
Thanks! https://codereview.chromium.org/2898243002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java File chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java (right): https://codereview.chromium.org/2898243002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java#newcode60 chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java:60: ((ViewGroup) container.findViewById(R.id.overview_list_layout_holder)) On 2017/05/24 18:58:23, David Trainor-ping if ...
3 years, 7 months ago (2017-05-24 19:16:35 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898243002/1
3 years, 7 months ago (2017-05-24 19:17:32 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 20:56:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7dfe6af12787999c6f219ae1df78...

Powered by Google App Engine
This is Rietveld 408576698