Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1115)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java

Issue 2898243002: [Android] Add OverviewListLayout to main CoordinatorLayout (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/layout/main.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java
index b5b2424dab265a331d785125204b54c73349b11a..7a9177e75bd49a856249cef8716576e00c849cba 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/widget/OverviewListLayout.java
@@ -55,11 +55,10 @@ public class OverviewListLayout extends Layout implements AccessibilityTabModelA
adjustForFullscreen();
}
- if (container == null) return;
+ if (container == null || mTabModelWrapper.getParent() != null) return;
- if (mTabModelWrapper.getParent() == null) {
- container.addView(mTabModelWrapper);
- }
+ ((ViewGroup) container.findViewById(R.id.overview_list_layout_holder))
David Trainor- moved to gerrit 2017/05/24 18:58:23 Hmm should "container" just be this new ViewGroup?
Theresa 2017/05/24 19:16:35 Possibly. I'd need to look at each thing that exte
+ .addView(mTabModelWrapper);
}
@Override
« no previous file with comments | « chrome/android/java/res/layout/main.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698