Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 289823002: SPDY4: SpdySession should send SETTINGS acknowledgements. (Closed)

Created:
6 years, 7 months ago by Johnny
Modified:
6 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

SPDY4: SpdySession should send SETTINGS acknowledgements. Queued immediately after an OnSettings() visitor call. Use a placeholder frame as needed in impacted tests, so that test flow isn't protocol-version dependent. BUG=345769 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -36 lines) Patch
M net/spdy/spdy_network_transaction_unittest.cc View 12 chunks +27 lines, -11 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 7 chunks +30 lines, -17 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M net/spdy/spdy_websocket_stream_unittest.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M net/spdy/spdy_websocket_test_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/spdy/spdy_websocket_test_util.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Johnny
6 years, 7 months ago (2014-05-14 20:29:28 UTC) #1
Ryan Hamilton
lgtm
6 years, 7 months ago (2014-05-15 17:47:00 UTC) #2
Johnny
The CQ bit was checked by jgraettinger@chromium.org
6 years, 7 months ago (2014-05-15 18:13:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jgraettinger@chromium.org/289823002/1
6 years, 7 months ago (2014-05-15 18:17:19 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 19:21:33 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 20:45:24 UTC) #6
Message was sent while issue was closed.
Change committed as 270807

Powered by Google App Engine
This is Rietveld 408576698