Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Unified Diff: net/spdy/spdy_test_util_common.cc

Issue 289823002: SPDY4: SpdySession should send SETTINGS acknowledgements. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_test_util_common.h ('k') | net/spdy/spdy_websocket_stream_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_test_util_common.cc
diff --git a/net/spdy/spdy_test_util_common.cc b/net/spdy/spdy_test_util_common.cc
index 3926ebd5bf83041a3358239bda271d6381c49c69..671016410f095bda712f3add456b73bb8c3205ac 100644
--- a/net/spdy/spdy_test_util_common.cc
+++ b/net/spdy/spdy_test_util_common.cc
@@ -864,6 +864,18 @@ SpdyFrame* SpdyTestUtil::ConstructSpdySettings(
return CreateFramer(false)->SerializeFrame(settings_ir);
}
+SpdyFrame* SpdyTestUtil::ConstructSpdySettingsAck() const {
+ char kEmptyWrite[] = "";
+
+ if (spdy_version() > SPDY3) {
+ SpdySettingsIR settings_ir;
+ settings_ir.set_is_ack(true);
+ return CreateFramer(false)->SerializeFrame(settings_ir);
+ }
+ // No settings ACK write occurs. Create an empty placeholder write.
+ return new SpdyFrame(kEmptyWrite, 0, false);
+}
+
SpdyFrame* SpdyTestUtil::ConstructSpdyPing(uint32 ping_id, bool is_ack) const {
SpdyPingIR ping_ir(ping_id);
ping_ir.set_is_ack(is_ack);
« no previous file with comments | « net/spdy/spdy_test_util_common.h ('k') | net/spdy/spdy_websocket_stream_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698