SPDY4: SpdySession should send SETTINGS acknowledgements.

net/spdy/spdy_websocket_stream_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_websocket_stream.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 544 matching lines @@
   EXPECT_EQ(SpdyWebSocketStreamEvent::EVENT_CLOSE, events[4].event_type);
 
   EXPECT_TRUE(
       HasSpdySession(http_session_->spdy_session_pool(), spdy_session_key_));
 }
 
 TEST_P(SpdyWebSocketStreamTest, IOPending) {
   Prepare(1);
   scoped_ptr<SpdyFrame> settings_frame(
       spdy_util_.ConstructSpdySettings(spdy_settings_to_send_));
+  scoped_ptr<SpdyFrame> settings_ack(spdy_util_.ConstructSpdySettingsAck());
   MockWrite writes[] = {
-    CreateMockWrite(*request_frame_.get(), 1),
-    CreateMockWrite(*message_frame_.get(), 3),
-    CreateMockWrite(*closing_frame_.get(), 5)
+    CreateMockWrite(*settings_ack, 1),
+    CreateMockWrite(*request_frame_.get(), 2),
+    CreateMockWrite(*message_frame_.get(), 4),
+    CreateMockWrite(*closing_frame_.get(), 6)
   };
 
   MockRead reads[] = {
     CreateMockRead(*settings_frame.get(), 0),
-    CreateMockRead(*response_frame_.get(), 2),
-    CreateMockRead(*message_frame_.get(), 4),
-    CreateMockRead(*closing_frame_.get(), 6),
-    MockRead(SYNCHRONOUS, 0, 7)  // EOF cause OnCloseSpdyStream event.
+    CreateMockRead(*response_frame_.get(), 3),
+    CreateMockRead(*message_frame_.get(), 5),
+    CreateMockRead(*closing_frame_.get(), 7),
+    MockRead(SYNCHRONOUS, 0, 8)  // EOF cause OnCloseSpdyStream event.
   };
 
   DeterministicSocketData data(reads, arraysize(reads),
                                writes, arraysize(writes));
   session_deps_.deterministic_socket_factory->AddSocketDataProvider(&data);
   http_session_ =
       SpdySessionDependencies::SpdyCreateSessionDeterministic(&session_deps_);
 
   session_ = CreateInsecureSpdySession(
       http_session_, spdy_session_key_, BoundNetLog());
@@ skipping 28 matching lines @@
   GURL url("ws://example.com/echo");
   ASSERT_EQ(ERR_IO_PENDING, websocket_stream_->InitializeStream(
       url, HIGHEST, net_log));
 
   // Delete the fist stream to allow create the second stream.
   block_stream.reset();
   ASSERT_EQ(OK, sync_callback_.WaitForResult());
 
   SendRequest();
 
-  data.RunFor(7);
+  data.RunFor(8);
   completion_callback_.WaitForResult();
 
   websocket_stream_.reset();
 
   const std::vector<SpdyWebSocketStreamEvent>& block_events =
       block_delegate.GetSeenEvents();
   ASSERT_EQ(0U, block_events.size());
 
   const std::vector<SpdyWebSocketStreamEvent>& events =
       delegate.GetSeenEvents();
@@ skipping 24 matching lines @@
   EXPECT_EQ(OK, events[7].result);
 
   // EOF close SPDY session.
   EXPECT_FALSE(
       HasSpdySession(http_session_->spdy_session_pool(), spdy_session_key_));
   EXPECT_TRUE(data.at_read_eof());
   EXPECT_TRUE(data.at_write_eof());
 }
 
 }  // namespace net