Revert "Revert of Allow use of Mojo/V8 ProxyResolvers with URLRequestContextBuilder. (patchset #10 …

Allow use of Mojo/V8 ProxyResolvers with URLRequestContextBuilder.

This adds URLRequestContextBuilderV8, which can construct a
URLRequestContext using either type of ProxyResolver. When using such
a resolver, the ProxyService will fetch requests using the
URLRequestContext that was created with the builder.

Added a subclass instead of modifying URLRequestContextBuilder so it
can continue to be used without depending on V8.

This was originally landed in
https://codereview.chromium.org/2881613002/, and reverted in
https://codereview.chromium.org/2888043008/.  This version of the CL
fixes a test-only lifetime issue.

BUG=717253, 724471
Review-Url: https://codereview.chromium.org/2898073002
Cr-Commit-Position: refs/heads/master@{#473933}
Committed: https://chromium.googlesource.com/chromium/src/+/93be9ca690ac29ad965a7f7bf6f899cf05c0c582

[mmenke, 2017-05-22 22:09:05]

Description was changed from

==========
Revert "Revert of Allow use of Mojo/V8 ProxyResolvers with
URLRequestContextBuilder. (patchset #10 id:280001 of
https://codereview.chromium.org/2881613002/ )"

This reverts commit b7060318b0cc8ccf7f4572104d08580919f1a733.

BUG=717253, 724471
==========

to

==========
Allow use of Mojo/V8 ProxyResolvers with URLRequestContextBuilder.

This adds URLRequestContextBuilderV8, which can construct a
URLRequestContext using either type of ProxyResolver. When using such
a resolver, the ProxyService will fetch requests using the
URLRequestContext that was created with the builder.

Added a subclass instead of modifying URLRequestContextBuilder so it
can continue to be used without depending on V8.

This was originally landed in https://codereview.chromium.org/2881613002/, and
reverted in https://codereview.chromium.org/2888043008/.  This CL fixes a
test-only lifetime issue.

BUG=717253, 724471
==========

[mmenke, 2017-05-22 22:09:26]

Description was changed from

==========
Allow use of Mojo/V8 ProxyResolvers with URLRequestContextBuilder.

This adds URLRequestContextBuilderV8, which can construct a
URLRequestContext using either type of ProxyResolver. When using such
a resolver, the ProxyService will fetch requests using the
URLRequestContext that was created with the builder.

Added a subclass instead of modifying URLRequestContextBuilder so it
can continue to be used without depending on V8.

This was originally landed in https://codereview.chromium.org/2881613002/, and
reverted in https://codereview.chromium.org/2888043008/.  This CL fixes a
test-only lifetime issue.

BUG=717253, 724471
==========

to

==========
Allow use of Mojo/V8 ProxyResolvers with URLRequestContextBuilder.

This adds URLRequestContextBuilderV8, which can construct a
URLRequestContext using either type of ProxyResolver. When using such
a resolver, the ProxyService will fetch requests using the
URLRequestContext that was created with the builder.

Added a subclass instead of modifying URLRequestContextBuilder so it
can continue to be used without depending on V8.

This was originally landed in
https://codereview.chromium.org/2881613002/, and reverted in
https://codereview.chromium.org/2888043008/.  This version of the CL
fixes a test-only lifetime issue.

BUG=717253, 724471
==========

[mmenke, 2017-05-22 22:10:20]

mmenke@chromium.org changed reviewers:
+ eroman@chromium.org

[mmenke, 2017-05-22 22:10:21]

Set 1 is the original patch, and set 2 is the one with the putative fix.

[mmenke, 2017-05-22 22:10:31]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 22:10:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 22:27:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 22:27:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmenke, 2017-05-22 22:54:04]

On 2017/05/22 22:10:21, mmenke wrote:
> Set 1 is the original patch, and set 2 is the one with the putative fix.

Oops, forgot an EXPECT_TRUE around the shutdown line - I'll add it tomorrow.

[eroman, 2017-05-22 23:08:55]

lgtm with that fix.

[mmenke, 2017-05-23 15:00:07]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 15:00:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-05-23 15:11:37]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2017-05-23 15:11:43]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2017-05-23 15:11:43]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2898073002/#ps40001
(title: "Add EXPECT_TRUE")

[commit-bot: I haz the power, 2017-05-23 15:11:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-05-23 16:19:00]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2017-05-23 16:19:14]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-05-23 16:19:51]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 16:29:24]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495556354441640,
"parent_rev": "d465e31bd450870f7191218231b0180f163421bb", "commit_rev":
"93be9ca690ac29ad965a7f7bf6f899cf05c0c582"}

[commit-bot: I haz the power, 2017-05-23 16:29:41]

Description was changed from

==========
Allow use of Mojo/V8 ProxyResolvers with URLRequestContextBuilder.

This adds URLRequestContextBuilderV8, which can construct a
URLRequestContext using either type of ProxyResolver. When using such
a resolver, the ProxyService will fetch requests using the
URLRequestContext that was created with the builder.

Added a subclass instead of modifying URLRequestContextBuilder so it
can continue to be used without depending on V8.

This was originally landed in
https://codereview.chromium.org/2881613002/, and reverted in
https://codereview.chromium.org/2888043008/.  This version of the CL
fixes a test-only lifetime issue.

BUG=717253, 724471
==========

to

==========
Allow use of Mojo/V8 ProxyResolvers with URLRequestContextBuilder.

This adds URLRequestContextBuilderV8, which can construct a
URLRequestContext using either type of ProxyResolver. When using such
a resolver, the ProxyService will fetch requests using the
URLRequestContext that was created with the builder.

Added a subclass instead of modifying URLRequestContextBuilder so it
can continue to be used without depending on V8.

This was originally landed in
https://codereview.chromium.org/2881613002/, and reverted in
https://codereview.chromium.org/2888043008/.  This version of the CL
fixes a test-only lifetime issue.

BUG=717253, 724471

Review-Url: https://codereview.chromium.org/2898073002
Cr-Commit-Position: refs/heads/master@{#473933}
Committed:
https://chromium.googlesource.com/chromium/src/+/93be9ca690ac29ad965a7f7bf6f8...
==========

[commit-bot: I haz the power, 2017-05-23 16:29:42]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/93be9ca690ac29ad965a7f7bf6f8...