Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2888043008: Revert of Allow use of Mojo/V8 ProxyResolvers with URLRequestContextBuilder. (Closed)

Created:
6 months, 1 week ago by pasko
Modified:
6 months, 1 week ago
Reviewers:
eroman, mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Allow use of Mojo/V8 ProxyResolvers with URLRequestContextBuilder. (patchset #10 id:280001 of https://codereview.chromium.org/2881613002/ ) Reason for revert: http://crbug.com/724471 V8InProcessShutdownWithHungRequest flaky on a cronet bot Original issue's description: > Allow use of Mojo/V8 ProxyResolvers with URLRequestContextBuilder. > > This adds URLRequestContextBuilderV8, which can construct a > URLRequestContext using either type of ProxyResolver. When using such > a resolver, the ProxyService will fetch requests using the > URLRequestContext that was created with the builder. > > Added a subclass instead of modifying URLRequestContextBuilder so it > can continue to be used without depending on V8. > > BUG=717253 > > Review-Url: https://codereview.chromium.org/2881613002 > Cr-Commit-Position: refs/heads/master@{#472439} > Committed: https://chromium.googlesource.com/chromium/src/+/f4fc1f04fe1a0d835a508720fdd90841a8d1583b TBR=eroman@chromium.org,mmenke@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=717253 Review-Url: https://codereview.chromium.org/2888043008 Cr-Commit-Position: refs/heads/master@{#473182} Committed: https://chromium.googlesource.com/chromium/src/+/b7060318b0cc8ccf7f4572104d08580919f1a733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -589 lines) Patch
M net/BUILD.gn View 8 chunks +6 lines, -47 lines 0 comments Download
M net/proxy/proxy_script_fetcher_impl_unittest.cc View 4 chunks +33 lines, -5 lines 0 comments Download
M net/proxy/proxy_service_mojo_unittest.cc View 4 chunks +32 lines, -2 lines 0 comments Download
D net/proxy/test_mojo_proxy_resolver_factory.h View 1 chunk +0 lines, -52 lines 0 comments Download
D net/proxy/test_mojo_proxy_resolver_factory.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M net/test/embedded_test_server/http_request.cc View 1 chunk +1 line, -1 line 0 comments Download
D net/test/embedded_test_server/simple_connection_listener.h View 1 chunk +0 lines, -67 lines 0 comments Download
D net/test/embedded_test_server/simple_connection_listener.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M net/url_request/url_request_context_builder.h View 3 chunks +1 line, -17 lines 0 comments Download
M net/url_request/url_request_context_builder.cc View 4 chunks +19 lines, -40 lines 0 comments Download
D net/url_request/url_request_context_builder_v8.h View 1 chunk +0 lines, -92 lines 0 comments Download
D net/url_request/url_request_context_builder_v8.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D net/url_request/url_request_context_builder_v8_unittest.cc View 1 chunk +0 lines, -127 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
pasko
Created Revert of Allow use of Mojo/V8 ProxyResolvers with URLRequestContextBuilder.
6 months, 1 week ago (2017-05-19 12:41:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2888043008/1
6 months, 1 week ago (2017-05-19 12:41:27 UTC) #3
commit-bot: I haz the power
6 months, 1 week ago (2017-05-19 14:41:32 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b7060318b0cc8ccf7f4572104d08...

Powered by Google App Engine
This is Rietveld efc10ee0f