DOMTokenList.contains() should not throw.

DOMTokenList.contains() should not throw.

https://dom.spec.whatwg.org/#dom-domtokenlist-contains-token-token
https://dom.spec.whatwg.org/#dom-domtokenlist-contains
New behavior matches to the DOM standard, Firefox, and Safari.

This CL fixes 60 failing tests in wpt/dom/.

BUG=600964
Review-Url: https://codereview.chromium.org/2898063003
Cr-Commit-Position: refs/heads/master@{#473826}
Committed: https://chromium.googlesource.com/chromium/src/+/719237584073bc2ef77a64e4f8b1514e66ef037e

[tkent, 2017-05-23 00:18:33]

The CQ bit was checked by tkent@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 00:19:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 02:25:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 02:25:29]

Dry run: This issue passed the CQ dry run.

[tkent, 2017-05-23 02:33:57]

Description was changed from

==========
DOMTokenList.contains() should not throw.

BUG=600964
==========

to

==========
DOMTokenList.contains() should not throw.

https://dom.spec.whatwg.org/#dom-domtokenlist-contains-token-token
https://dom.spec.whatwg.org/#dom-domtokenlist-contains
New behavior matches to the DOM standard, Firefox, and Safari.

BUG=600964
==========

[tkent, 2017-05-23 02:34:23]

tkent@chromium.org changed reviewers:
+ kochi@chromium.org

[tkent, 2017-05-23 02:34:24]

kochi@, would you review this please?

[kochi, 2017-05-23 04:15:01]

LGTM with one minor nit.

https://codereview.chromium.org/2898063003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/DOMTokenList.cpp (right):

https://codereview.chromium.org/2898063003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/DOMTokenList.cpp:71: //
https://dom.spec.whatwg.org/#dom-domtokenlist-contains
nit: comment above function? (see line 63 for example)

[tkent, 2017-05-23 05:19:38]

https://codereview.chromium.org/2898063003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/DOMTokenList.cpp (right):

https://codereview.chromium.org/2898063003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/DOMTokenList.cpp:71: //
https://dom.spec.whatwg.org/#dom-domtokenlist-contains
On 2017/05/23 at 04:15:01, kochi wrote:
> nit: comment above function? (see line 63 for example)

Done.

[tkent, 2017-05-23 05:19:48]

The CQ bit was checked by tkent@chromium.org

[tkent, 2017-05-23 05:19:49]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/2898063003/#ps20001
(title: "Move the comment")

[commit-bot: I haz the power, 2017-05-23 05:20:03]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tkent, 2017-05-23 05:21:13]

Description was changed from

==========
DOMTokenList.contains() should not throw.

https://dom.spec.whatwg.org/#dom-domtokenlist-contains-token-token
https://dom.spec.whatwg.org/#dom-domtokenlist-contains
New behavior matches to the DOM standard, Firefox, and Safari.

BUG=600964
==========

to

==========
DOMTokenList.contains() should not throw.

https://dom.spec.whatwg.org/#dom-domtokenlist-contains-token-token
https://dom.spec.whatwg.org/#dom-domtokenlist-contains
New behavior matches to the DOM standard, Firefox, and Safari.

This CL fixes 60 failing tests in wpt/dom/.

BUG=600964
==========

[commit-bot: I haz the power, 2017-05-23 07:25:47]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495516788697190,
"parent_rev": "43934f6a9f928b71699b8cae213205a164b80985", "commit_rev":
"719237584073bc2ef77a64e4f8b1514e66ef037e"}

[commit-bot: I haz the power, 2017-05-23 07:25:58]

Description was changed from

==========
DOMTokenList.contains() should not throw.

https://dom.spec.whatwg.org/#dom-domtokenlist-contains-token-token
https://dom.spec.whatwg.org/#dom-domtokenlist-contains
New behavior matches to the DOM standard, Firefox, and Safari.

This CL fixes 60 failing tests in wpt/dom/.

BUG=600964
==========

to

==========
DOMTokenList.contains() should not throw.

https://dom.spec.whatwg.org/#dom-domtokenlist-contains-token-token
https://dom.spec.whatwg.org/#dom-domtokenlist-contains
New behavior matches to the DOM standard, Firefox, and Safari.

This CL fixes 60 failing tests in wpt/dom/.

BUG=600964

Review-Url: https://codereview.chromium.org/2898063003
Cr-Commit-Position: refs/heads/master@{#473826}
Committed:
https://chromium.googlesource.com/chromium/src/+/719237584073bc2ef77a64e4f8b1...
==========

[commit-bot: I haz the power, 2017-05-23 07:25:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/719237584073bc2ef77a64e4f8b1...