third_party/WebKit/Source/core/dom/DOMTokenList.h - Issue 2898063003: DOMTokenList.contains() should not throw.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DOMTokenList.h

Issue 2898063003: DOMTokenList.contains() should not throw. (Closed)

Patch Set: Move the comment Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/DOMTokenList.h

diff --git a/third_party/WebKit/Source/core/dom/DOMTokenList.h b/third_party/WebKit/Source/core/dom/DOMTokenList.h

index 5a51766ae860edbf808b1db912d4cfbae10b79b2..d7e8776c7027158c25bcef5969645a907232e0f6 100644

--- a/third_party/WebKit/Source/core/dom/DOMTokenList.h

+++ b/third_party/WebKit/Source/core/dom/DOMTokenList.h

@@ -60,7 +60,7 @@ class CORE_EXPORT DOMTokenList : public GarbageCollectedFinalized<DOMTokenList>,

virtual unsigned length() const { return tokens_.size(); }

virtual const AtomicString item(unsigned index) const;

- bool contains(const AtomicString&, ExceptionState&) const;

+ bool contains(const AtomicString&) const;

virtual void add(const Vector<String>&, ExceptionState&);

void add(const AtomicString&, ExceptionState&);

virtual void remove(const Vector<String>&, ExceptionState&);