Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2898033002: [TabManager] Move TabManager into chrome/browser/resource_coordinator. (Closed)

Created:
3 years, 7 months ago by lpy
Modified:
3 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[TabManager] Move TabManager into chrome/browser/resource_coordinator. This patch moves TabManager and other related class into chrome/browser/resource_coordinator, they are tab_manager* and tab_stats.*, header include and BUILD files are also updated. Review-Url: https://codereview.chromium.org/2898033002 Cr-Commit-Position: refs/heads/master@{#476136} Committed: https://chromium.googlesource.com/chromium/src/+/fedf65a53b4a7f5f88bde8f71fe1ebdfb80c3696

Patch Set 1 #

Patch Set 2 : Fix chromeos build and add owners #

Patch Set 3 : Add namespace resource_coordinator #

Patch Set 4 : rebase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -4908 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/browser_process.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/browser_process_impl.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_event_router.h View 1 2 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_event_router.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_test.cc View 1 2 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/memory/DEPS View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/memory/chrome_memory_coordinator_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/memory/tab_manager.h View 1 chunk +0 lines, -376 lines 0 comments Download
D chrome/browser/memory/tab_manager.cc View 1 chunk +0 lines, -878 lines 0 comments Download
D chrome/browser/memory/tab_manager_browsertest.cc View 1 chunk +0 lines, -587 lines 0 comments Download
D chrome/browser/memory/tab_manager_delegate_chromeos.h View 1 2 3 1 chunk +0 lines, -277 lines 0 comments Download
D chrome/browser/memory/tab_manager_delegate_chromeos.cc View 1 2 3 1 chunk +0 lines, -776 lines 0 comments Download
D chrome/browser/memory/tab_manager_delegate_chromeos_unittest.cc View 1 chunk +0 lines, -448 lines 0 comments Download
D chrome/browser/memory/tab_manager_observer.h View 1 chunk +0 lines, -33 lines 0 comments Download
D chrome/browser/memory/tab_manager_observer.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/memory/tab_manager_observer_browsertest.cc View 1 chunk +0 lines, -189 lines 0 comments Download
D chrome/browser/memory/tab_manager_unittest.cc View 1 chunk +0 lines, -497 lines 0 comments Download
D chrome/browser/memory/tab_manager_web_contents_data.h View 1 2 1 chunk +0 lines, -152 lines 0 comments Download
D chrome/browser/memory/tab_manager_web_contents_data.cc View 1 2 1 chunk +0 lines, -204 lines 0 comments Download
D chrome/browser/memory/tab_manager_web_contents_data_unittest.cc View 1 chunk +0 lines, -207 lines 0 comments Download
D chrome/browser/memory/tab_stats.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/memory/tab_stats.cc View 1 chunk +0 lines, -20 lines 0 comments Download
A + chrome/browser/resource_coordinator/DEPS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resource_coordinator/OWNERS View 1 2 1 chunk +4 lines, -1 line 0 comments Download
A + chrome/browser/resource_coordinator/tab_manager.h View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/resource_coordinator/tab_manager.cc View 1 2 7 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/resource_coordinator/tab_manager_browsertest.cc View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
A + chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.h View 1 2 3 4 chunks +7 lines, -7 lines 0 comments Download
A + chrome/browser/resource_coordinator/tab_manager_delegate_chromeos.cc View 1 2 3 17 chunks +30 lines, -34 lines 0 comments Download
A + chrome/browser/resource_coordinator/tab_manager_delegate_chromeos_unittest.cc View 1 2 6 chunks +8 lines, -17 lines 0 comments Download
A + chrome/browser/resource_coordinator/tab_manager_observer.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/resource_coordinator/tab_manager_observer.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/resource_coordinator/tab_manager_observer_browsertest.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/resource_coordinator/tab_manager_unittest.cc View 1 2 6 chunks +9 lines, -11 lines 0 comments Download
A + chrome/browser/resource_coordinator/tab_manager_web_contents_data.h View 1 2 3 chunks +6 lines, -6 lines 0 comments Download
A + chrome/browser/resource_coordinator/tab_manager_web_contents_data.cc View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
A + chrome/browser/resource_coordinator/tab_manager_web_contents_data_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/resource_coordinator/tab_stats.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
A + chrome/browser/resource_coordinator/tab_stats.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 1 2 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 3 chunks +5 lines, -5 lines 1 comment Download
M chrome/test/base/testing_browser_process.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/base/testing_browser_process.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 45 (28 generated)
lpy
chrisha@, ptal. cylee@, could you please take a look at chromeos related files?
3 years, 7 months ago (2017-05-22 18:31:51 UTC) #4
cylee1
I have no problem with tab_manager_delegate_chromeos* . I'll leave lgtm to chrisha though. Also do ...
3 years, 7 months ago (2017-05-22 19:07:20 UTC) #7
lpy
Thanks, I added owners.
3 years, 7 months ago (2017-05-22 20:16:07 UTC) #13
lpy
chrisha@, gentle ping for review.
3 years, 7 months ago (2017-05-23 17:02:49 UTC) #16
chrisha
We should probably use a namespace for resource_coordinator. nduca, thoughts?
3 years, 6 months ago (2017-05-25 17:52:14 UTC) #18
lpy
It looks like it will eventually become tab coordination? So how about tab_coordinator? +oysteine@ for ...
3 years, 6 months ago (2017-05-25 17:54:48 UTC) #20
lpy
oysteine@, gentle ping for input.
3 years, 6 months ago (2017-05-30 16:06:46 UTC) #21
nduca
I'd defer to oysteine. I'd personally go for resource_coordinator or rc or grc... chrome composior ...
3 years, 6 months ago (2017-05-30 17:14:26 UTC) #22
oystein (OOO til 10th of July)
On 2017/05/30 at 17:14:26, nduca wrote: > I'd defer to oysteine. I'd personally go for ...
3 years, 6 months ago (2017-05-30 17:26:35 UTC) #23
oystein (OOO til 10th of July)
On 2017/05/30 at 17:26:35, oystein wrote: > On 2017/05/30 at 17:14:26, nduca wrote: > > ...
3 years, 6 months ago (2017-05-30 17:26:53 UTC) #24
lpy
Thanks, I updated the CL. chrisha@, ptal.
3 years, 6 months ago (2017-05-30 20:42:44 UTC) #26
chrisha
With the namespace, I'm happy with this. lgtm!
3 years, 6 months ago (2017-05-31 18:51:04 UTC) #30
lpy
+sky@ for chrome/browser/resource_coordinator/DEPS, ptal
3 years, 6 months ago (2017-05-31 20:49:54 UTC) #33
sky
DEPS move LGTM
3 years, 6 months ago (2017-05-31 21:05:19 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2898033002/80001
3 years, 6 months ago (2017-05-31 23:52:59 UTC) #40
commit-bot: I haz the power
Committed patchset #4 (id:80001) as https://chromium.googlesource.com/chromium/src/+/fedf65a53b4a7f5f88bde8f71fe1ebdfb80c3696
3 years, 6 months ago (2017-06-01 01:41:38 UTC) #43
Lei Zhang
3 years, 6 months ago (2017-06-08 20:53:05 UTC) #45
Message was sent while issue was closed.
https://codereview.chromium.org/2898033002/diff/80001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2898033002/diff/80001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:3550:
"../browser/resource_coordinator/tab_manager_delegate_chromeos_unittest.cc",
Please move these down to keep the overall list sorted.

Powered by Google App Engine
This is Rietveld 408576698