[TabManager] Move TabManager into chrome/browser/resource_coordinator.

[TabManager] Move TabManager into chrome/browser/resource_coordinator.

This patch moves TabManager and other related class into
chrome/browser/resource_coordinator, they are tab_manager* and tab_stats.*,
header include and BUILD files are also updated.

Review-Url: https://codereview.chromium.org/2898033002
Cr-Commit-Position: refs/heads/master@{#476136}
Committed: https://chromium.googlesource.com/chromium/src/+/fedf65a53b4a7f5f88bde8f71fe1ebdfb80c3696

[lpy, 2017-05-22 18:29:11]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 18:30:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2017-05-22 18:31:50]

lpy@chromium.org changed reviewers:
+ chrisha@chromium.org, cylee@chromium.org

[lpy, 2017-05-22 18:31:51]

chrisha@, ptal.

cylee@, could you please take a look at chromeos related files?

[commit-bot: I haz the power, 2017-05-22 18:48:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 18:48:08]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[cylee1, 2017-05-22 19:07:20]

I have no problem with tab_manager_delegate_chromeos* .
I'll leave lgtm to chrisha though.

Also do you forget the OWNERS file ?

[lpy, 2017-05-22 19:46:52]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 19:47:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2017-05-22 19:53:04]

Patchset #2 (id:20001) has been deleted

[lpy, 2017-05-22 19:53:42]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 19:54:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lpy, 2017-05-22 20:16:07]

Thanks, I added owners.

[commit-bot: I haz the power, 2017-05-22 21:14:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 21:14:40]

Dry run: This issue passed the CQ dry run.

[lpy, 2017-05-23 17:02:49]

chrisha@, gentle ping for review.

[chrisha, 2017-05-25 17:52:13]

chrisha@chromium.org changed reviewers:
+ nduca@chromium.org

[chrisha, 2017-05-25 17:52:14]

We should probably use a namespace for resource_coordinator. nduca, thoughts?

[lpy, 2017-05-25 17:54:47]

lpy@chromium.org changed reviewers:
+ oysteine@chromium.org

[lpy, 2017-05-25 17:54:48]

It looks like it will eventually become tab coordination? So how about
tab_coordinator?

+oysteine@ for input

[lpy, 2017-05-30 16:06:46]

oysteine@, gentle ping for input.

[nduca, 2017-05-30 17:14:26]

I'd defer to oysteine. I'd personally go for resource_coordinator or rc or
grc... chrome composior === $chrome/cc === ::cc, though in that case the
directory name matches the namespace matches the abbreviation.

[oystein (OOO til 10th of July), 2017-05-30 17:26:35]

On 2017/05/30 at 17:14:26, nduca wrote:
> I'd defer to oysteine. I'd personally go for resource_coordinator or rc or
grc... chrome composior === $chrome/cc === ::cc, though in that case the
directory name matches the namespace matches the abbreviation.

resource_coordinator is what we've used elsewhere (like in the service); let's
stick with that.

[oystein (OOO til 10th of July), 2017-05-30 17:26:53]

On 2017/05/30 at 17:26:35, oystein wrote:
> On 2017/05/30 at 17:14:26, nduca wrote:
> > I'd defer to oysteine. I'd personally go for resource_coordinator or rc or
grc... chrome composior === $chrome/cc === ::cc, though in that case the
directory name matches the namespace matches the abbreviation.
> 
> resource_coordinator is what we've used elsewhere (like in the service); let's
stick with that.

(it shouldn't be tab_coordinator as that's just the first part of this)

[lpy, 2017-05-30 20:41:59]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[lpy, 2017-05-30 20:42:44]

Thanks, I updated the CL. chrisha@, ptal.

[commit-bot: I haz the power, 2017-05-30 20:42:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-31 00:02:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 00:02:41]

Dry run: This issue passed the CQ dry run.

[chrisha, 2017-05-31 18:51:04]

With the namespace, I'm happy with this.

lgtm!

[lpy, 2017-05-31 20:48:48]

The CQ bit was checked by lpy@chromium.org to run a CQ dry run

[lpy, 2017-05-31 20:49:54]

lpy@chromium.org changed reviewers:
+ sky@chromium.org

[lpy, 2017-05-31 20:49:54]

+sky@ for chrome/browser/resource_coordinator/DEPS, ptal

[commit-bot: I haz the power, 2017-05-31 20:49:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2017-05-31 21:05:19]

DEPS move LGTM

[commit-bot: I haz the power, 2017-05-31 23:42:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-31 23:42:09]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[lpy, 2017-05-31 23:52:23]

The CQ bit was checked by lpy@chromium.org

[lpy, 2017-05-31 23:52:24]

The patchset sent to the CQ was uploaded after l-g-t-m from cylee@chromium.org,
chrisha@chromium.org
Link to the patchset: https://codereview.chromium.org/2898033002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-31 23:52:59]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-01 01:41:27]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1496274743945550,
"parent_rev": "f1e6a615e165c9ad4e33b4f50dd23e9ee9fab5be", "commit_rev":
"fedf65a53b4a7f5f88bde8f71fe1ebdfb80c3696"}

[commit-bot: I haz the power, 2017-06-01 01:41:36]

Description was changed from

==========
[TabManager] Move TabManager into chrome/browser/resource_coordinator.

This patch moves TabManager and other related class into
chrome/browser/resource_coordinator, they are tab_manager* and tab_stats.*,
header include and BUILD files are also updated.
==========

to

==========
[TabManager] Move TabManager into chrome/browser/resource_coordinator.

This patch moves TabManager and other related class into
chrome/browser/resource_coordinator, they are tab_manager* and tab_stats.*,
header include and BUILD files are also updated.

Review-Url: https://codereview.chromium.org/2898033002
Cr-Commit-Position: refs/heads/master@{#476136}
Committed:
https://chromium.googlesource.com/chromium/src/+/fedf65a53b4a7f5f88bde8f71fe1...
==========

[commit-bot: I haz the power, 2017-06-01 01:41:38]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/fedf65a53b4a7f5f88bde8f71fe1...

[Lei Zhang, 2017-06-08 20:53:04]

thestig@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2017-06-08 20:53:05]

https://codereview.chromium.org/2898033002/diff/80001/chrome/test/BUILD.gn
File chrome/test/BUILD.gn (right):

https://codereview.chromium.org/2898033002/diff/80001/chrome/test/BUILD.gn#ne...
chrome/test/BUILD.gn:3550:
"../browser/resource_coordinator/tab_manager_delegate_chromeos_unittest.cc",
Please move these down to keep the overall list sorted.