Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2897953002: Remove loop unrolling code in UpdateYUVComponentSizes. (Closed)

Created:
3 years, 7 months ago by naga
Modified:
3 years, 6 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove loop unrolling code in UpdateYUVComponentSizes Remove loop unrolling to reduce code size in UpdateYUVComponentSizes by adding for loop. BUG=None Review-Url: https://codereview.chromium.org/2897953002 Cr-Commit-Position: refs/heads/master@{#475705} Committed: https://chromium.googlesource.com/chromium/src/+/7d18c710d2a6aa00cf8692e83598c7b9ee7733b0

Patch Set 1 #

Total comments: 1

Patch Set 2 : y #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp View 1 1 chunk +6 lines, -9 lines 0 comments Download

Messages

Total messages: 25 (14 generated)
Srirama
Peer review is fine. https://codereview.chromium.org/2897953002/diff/1/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp File third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp (right): https://codereview.chromium.org/2897953002/diff/1/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp#newcode104 third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp:104: for (int i = 0; ...
3 years, 7 months ago (2017-05-22 13:29:30 UTC) #3
naga
On 2017/05/22 13:29:30, Srirama wrote: > Peer review is fine. > > https://codereview.chromium.org/2897953002/diff/1/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp > File ...
3 years, 7 months ago (2017-05-22 13:43:15 UTC) #4
chrishtr
@scroggo, deferring to you on this. I don't know if this code is performance sensitive ...
3 years, 6 months ago (2017-05-30 18:26:06 UTC) #11
scroggo_chromium
On 2017/05/30 18:26:06, chrishtr wrote: > @scroggo, deferring to you on this. I don't know ...
3 years, 6 months ago (2017-05-30 19:25:00 UTC) #12
chrishtr
lgtm
3 years, 6 months ago (2017-05-30 19:58:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897953002/20001
3 years, 6 months ago (2017-05-30 19:59:18 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/306275)
3 years, 6 months ago (2017-05-30 22:36:11 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897953002/20001
3 years, 6 months ago (2017-05-30 22:59:14 UTC) #19
Noel Gordon
LGTM - seems ok, not bug though.
3 years, 6 months ago (2017-05-30 23:16:16 UTC) #20
Noel Gordon
On 2017/05/30 23:16:16, noel gordon wrote: > LGTM - seems ok, not bug though. Ahem, ...
3 years, 6 months ago (2017-05-31 00:19:17 UTC) #22
commit-bot: I haz the power
3 years, 6 months ago (2017-05-31 00:32:00 UTC) #25
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7d18c710d2a6aa00cf8692e83598...

Powered by Google App Engine
This is Rietveld 408576698