Remove loop unrolling code in UpdateYUVComponentSizes.

Remove loop unrolling code in UpdateYUVComponentSizes

Remove loop unrolling to reduce code size in UpdateYUVComponentSizes
by adding for loop.

BUG=None

Review-Url: https://codereview.chromium.org/2897953002
Cr-Commit-Position: refs/heads/master@{#475705}
Committed: https://chromium.googlesource.com/chromium/src/+/7d18c710d2a6aa00cf8692e83598c7b9ee7733b0

[naga, 2017-05-22 12:37:46]

Description was changed from

==========
Remove loop unrolling code in UpdateYUVComponentSizes.

Remove loop unrolling to reduce code size in UpdateYUVComponentSizes
by adding for loop.

BUG=None
==========

to

==========
Remove loop unrolling code in UpdateYUVComponentSizes.

Remove loop unrolling to reduce code size in UpdateYUVComponentSizes
by adding for loop.

BUG=None
R=SamsungPeerReview
==========

[naga, 2017-05-22 12:37:46]

nagarajan.n@samsung.com changed reviewers:
+ shanmuga.m@samsung.com, srirama.m@samsung.com

[Srirama, 2017-05-22 13:29:30]

Peer review is fine.

https://codereview.chromium.org/2897953002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp
(right):

https://codereview.chromium.org/2897953002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp:104: for
(int i = 0; i < 3; ++i) {
Suggestion: may be use componentIndex or some other better name instead of 'i'.

[naga, 2017-05-22 13:43:15]

On 2017/05/22 13:29:30, Srirama wrote:
> Peer review is fine.
> 
>
https://codereview.chromium.org/2897953002/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp
> (right):
> 
>
https://codereview.chromium.org/2897953002/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp:104: for
> (int i = 0; i < 3; ++i) {
> Suggestion: may be use componentIndex or some other better name instead of
'i'.

Updated the patch based on suggestion

[naga, 2017-05-22 13:46:12]

Description was changed from

==========
Remove loop unrolling code in UpdateYUVComponentSizes.

Remove loop unrolling to reduce code size in UpdateYUVComponentSizes
by adding for loop.

BUG=None
R=SamsungPeerReview
==========

to

==========
Remove loop unrolling code in UpdateYUVComponentSizes.

Remove loop unrolling to reduce code size in UpdateYUVComponentSizes
by adding for loop.

BUG=None
==========

[naga, 2017-05-22 13:46:12]

nagarajan.n@samsung.com changed reviewers:
+ schenney@chromium.org

[naga, 2017-05-23 04:06:24]

nagarajan.n@samsung.com changed reviewers:
+ chrishtr@chromium.org

[naga, 2017-05-23 06:11:27]

nagarajan.n@samsung.com changed reviewers:
+ pdr@chromium.org

[naga, 2017-05-25 11:06:59]

nagarajan.n@samsung.com changed reviewers:
+ scroggo@chromium.org

[naga, 2017-05-29 05:48:04]

nagarajan.n@samsung.com changed reviewers:
+ noel@chromium.org
- pdr@chromium.org

[chrishtr, 2017-05-30 18:26:06]

@scroggo, deferring to you on this. I don't know if this code is performance
sensitive enough
to justify the unrolling.

[scroggo_chromium, 2017-05-30 19:25:00]

On 2017/05/30 18:26:06, chrishtr wrote:
> @scroggo, deferring to you on this. I don't know if this code is performance
> sensitive enough
> to justify the unrolling.

No, I don't see any need to unroll this. LGTM. (You'll still need approval from
an OWNER, though.)

[chrishtr, 2017-05-30 19:58:18]

lgtm

[chrishtr, 2017-05-30 19:58:20]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-05-30 19:59:18]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 22:36:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 22:36:11]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[naga, 2017-05-30 22:58:32]

The CQ bit was checked by nagarajan.n@samsung.com

[commit-bot: I haz the power, 2017-05-30 22:59:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Noel Gordon, 2017-05-30 23:16:16]

LGTM - seems ok, not bug though.

[Noel Gordon, 2017-05-30 23:17:17]

Description was changed from

==========
Remove loop unrolling code in UpdateYUVComponentSizes.

Remove loop unrolling to reduce code size in UpdateYUVComponentSizes
by adding for loop.

BUG=None
==========

to

==========
Remove loop unrolling code in UpdateYUVComponentSizes

Remove loop unrolling to reduce code size in UpdateYUVComponentSizes
by adding for loop.

BUG=None
==========

[Noel Gordon, 2017-05-31 00:19:17]

On 2017/05/30 23:16:16, noel gordon wrote:
> LGTM - seems ok, not bug though.

Ahem, _no bug_ though.

[commit-bot: I haz the power, 2017-05-31 00:31:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1496185112232140,
"parent_rev": "9a6e17b873b960f3ec952187af2700b718e64580", "commit_rev":
"7d18c710d2a6aa00cf8692e83598c7b9ee7733b0"}

[commit-bot: I haz the power, 2017-05-31 00:31:58]

Description was changed from

==========
Remove loop unrolling code in UpdateYUVComponentSizes

Remove loop unrolling to reduce code size in UpdateYUVComponentSizes
by adding for loop.

BUG=None
==========

to

==========
Remove loop unrolling code in UpdateYUVComponentSizes

Remove loop unrolling to reduce code size in UpdateYUVComponentSizes
by adding for loop.

BUG=None

Review-Url: https://codereview.chromium.org/2897953002
Cr-Commit-Position: refs/heads/master@{#475705}
Committed:
https://chromium.googlesource.com/chromium/src/+/7d18c710d2a6aa00cf8692e83598...
==========

[commit-bot: I haz the power, 2017-05-31 00:32:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7d18c710d2a6aa00cf8692e83598...