Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2897893002: Generate getters/setters for subtree_is_sticky. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate getters/setters for subtree_is_sticky. Currently, the subtree_is_sticky field is 'storage_only', so it has no generated public getters/setters. This patch changes it to a 'primitive' field so that its getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/27b4a61fe64a79395888bf7f2b973fe0/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2897893002 Cr-Commit-Position: refs/heads/master@{#474586} Committed: https://chromium.googlesource.com/chromium/src/+/b1187d4dc292bec2734979125c72c26394c5c768

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M third_party/WebKit/Source/core/css/ComputedStyleExtraFields.json5 View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 1 chunk +0 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (15 generated)
shend
Hi Eddy, PTAL
3 years, 7 months ago (2017-05-24 00:35:03 UTC) #5
rune
lgtm
3 years, 7 months ago (2017-05-24 06:24:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897893002/20001
3 years, 7 months ago (2017-05-25 06:33:55 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 06:38:04 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b1187d4dc292bec2734979125c72...

Powered by Google App Engine
This is Rietveld 408576698