Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2897843002: Revert of [EasyUnlock] Add beacon_seeds to RemoteDevice. (Closed)

Created:
3 years, 7 months ago by tsergeant
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, hansberry+watch-tether_chromium.org, jhawkins+watch-tether_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [EasyUnlock] Add beacon_seeds to RemoteDevice. (patchset #6 id:120001 of https://codereview.chromium.org/2859053003/ ) Reason for revert: This CL causes the test CryptAuthRemoteDeviceLoaderTest.LoadDevicesWithAndWithoutBeaconSeeds from components_unittests to fail on MSan. See: https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20MSan%20Tests/1043 https://luci-milo.appspot.com/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/655 Original issue's description: > [EasyUnlock] Add beacon_seeds to RemoteDevice. > > Because BeaconSeeds can take quite a bit of space, we also add an option in > RemoteDeviceLoader whether or not to load the BeaconSeeds. > > Review-Url: https://codereview.chromium.org/2859053003 > Cr-Commit-Position: refs/heads/master@{#473489} > Committed: https://chromium.googlesource.com/chromium/src/+/c3636c2887c896911de99d208889b2582cf5e56b TBR=khorimoto@chromium.org,sacomoto@chromium.org,hansberry@chromium.org,jlklein@chromium.org,tengs@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2897843002 Cr-Commit-Position: refs/heads/master@{#473505} Committed: https://chromium.googlesource.com/chromium/src/+/ac674ab3c74b6471c0c24d44e622d4e12d18c042

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -174 lines) Patch
M chrome/browser/signin/easy_unlock_app_manager.cc View 2 chunks +6 lines, -12 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/components/tether/tether_host_fetcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/components/tether/tether_host_fetcher_unittest.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M components/cryptauth/remote_device.h View 3 chunks +0 lines, -10 lines 0 comments Download
M components/cryptauth/remote_device.cc View 3 chunks +6 lines, -45 lines 0 comments Download
M components/cryptauth/remote_device_loader.h View 1 chunk +1 line, -7 lines 0 comments Download
M components/cryptauth/remote_device_loader.cc View 3 chunks +4 lines, -16 lines 0 comments Download
M components/cryptauth/remote_device_loader_unittest.cc View 8 chunks +8 lines, -74 lines 0 comments Download
M components/proximity_auth/bluetooth_low_energy_connection_finder.h View 3 chunks +6 lines, -0 lines 0 comments Download
M components/proximity_auth/bluetooth_low_energy_connection_finder.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M components/proximity_auth/bluetooth_low_energy_connection_finder_unittest.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M components/proximity_auth/bluetooth_low_energy_setup_connection_finder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/proximity_auth/remote_device_life_cycle_impl.cc View 1 chunk +10 lines, -1 line 0 comments Download
M components/proximity_auth/webui/proximity_auth_webui_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
tsergeant
Created Revert of [EasyUnlock] Add beacon_seeds to RemoteDevice.
3 years, 7 months ago (2017-05-22 04:34:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897843002/1
3 years, 7 months ago (2017-05-22 04:34:18 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 04:35:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac674ab3c74b6471c0c24d44e622...

Powered by Google App Engine
This is Rietveld 408576698