Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2897833003: Generate getters/setters for tab-size. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Generate getters/setters for tab-size. Currently, the tab-size property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'external' field so that its getters/setters can be generated as well. Diff of generated files: https://gist.github.com/darrnshn/03ba56c31ca25cf9d6b254b7e47dd5e4/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2897833003 Cr-Commit-Position: refs/heads/master@{#474587} Committed: https://chromium.googlesource.com/chromium/src/+/d1573db133006bac1f7f43a90b93be8e64b721de

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +0 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (15 generated)
shend
Hi Eddy, PTAL
3 years, 7 months ago (2017-05-24 03:30:07 UTC) #3
rune
lgtm
3 years, 7 months ago (2017-05-24 06:14:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897833003/1
3 years, 7 months ago (2017-05-25 06:41:49 UTC) #16
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 06:45:22 UTC) #19
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d1573db133006bac1f7f43a90b93...

Powered by Google App Engine
This is Rietveld 408576698