DCHECK that property tree access is safe in LayerTreeImpl::DidUpdateScrollState

DCHECK that property tree access is safe in LayerTreeImpl::DidUpdateScrollState

This patch adds a DCHECK in LayerTreeImpl::DidUpdateScrollState that property
trees are synced and can be used. This required changing
PushPropertiesCountingLayerImpl to not call SetBounds in the ctor which was
not actually needed because the value would get synced.

This patch doesn't change behavior and just prepares for a future patch
which will use the scroll property tree to look up a LayerImpl's
scroll bounds instead of accessing this through scroll_clip_layer (e.g.,
clip_size in LayerTreeImpl::UpdateScrollbars).

BUG=723263
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2897703002
Cr-Commit-Position: refs/heads/master@{#473320}
Committed: https://chromium.googlesource.com/chromium/src/+/bf7130daaa2be71bdf491a8ae09685551ed98615

[pdr., 2017-05-19 18:35:43]

Description was changed from

==========
DCHECK that property tree access is safe in LayerTreeImpl::DidUpdateScrollState

This patch adds a DCHECK in LayerTreeImpl::DidUpdateScrollState that property
trees are synced and can be used. This required changing
PushPropertiesCountingLayerImpl to not call SetBounds in the ctor which was
not actually needed because the value would get synced.

This patch doesn't change behavior and just prepares for a future patch
which will use the scroll property tree to look up a LayerImpl's
scroll bounds instead of accessing this through scroll_clip_layer (e.g.,
clip_size in LayerTreeImpl::UpdateScrollbars).

BUG=723263
==========

to

==========
DCHECK that property tree access is safe in LayerTreeImpl::DidUpdateScrollState

This patch adds a DCHECK in LayerTreeImpl::DidUpdateScrollState that property
trees are synced and can be used. This required changing
PushPropertiesCountingLayerImpl to not call SetBounds in the ctor which was
not actually needed because the value would get synced.

This patch doesn't change behavior and just prepares for a future patch
which will use the scroll property tree to look up a LayerImpl's
scroll bounds instead of accessing this through scroll_clip_layer (e.g.,
clip_size in LayerTreeImpl::UpdateScrollbars).

BUG=723263
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[pdr., 2017-05-19 18:35:57]

pdr@chromium.org changed reviewers:
+ enne@chromium.org

[pdr., 2017-05-19 18:36:04]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 18:36:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2017-05-19 19:41:42]

lgtm

[commit-bot: I haz the power, 2017-05-19 21:11:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 21:11:48]

Dry run: This issue passed the CQ dry run.

[pdr., 2017-05-19 21:12:53]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2017-05-19 21:13:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 21:19:18]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495228373266870, "parent_rev":
"d4b0825f3059a63da4210b9e8fa1d53271d60b0d", "commit_rev":
"bf7130daaa2be71bdf491a8ae09685551ed98615"}

[commit-bot: I haz the power, 2017-05-19 21:19:30]

Description was changed from

==========
DCHECK that property tree access is safe in LayerTreeImpl::DidUpdateScrollState

This patch adds a DCHECK in LayerTreeImpl::DidUpdateScrollState that property
trees are synced and can be used. This required changing
PushPropertiesCountingLayerImpl to not call SetBounds in the ctor which was
not actually needed because the value would get synced.

This patch doesn't change behavior and just prepares for a future patch
which will use the scroll property tree to look up a LayerImpl's
scroll bounds instead of accessing this through scroll_clip_layer (e.g.,
clip_size in LayerTreeImpl::UpdateScrollbars).

BUG=723263
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
DCHECK that property tree access is safe in LayerTreeImpl::DidUpdateScrollState

This patch adds a DCHECK in LayerTreeImpl::DidUpdateScrollState that property
trees are synced and can be used. This required changing
PushPropertiesCountingLayerImpl to not call SetBounds in the ctor which was
not actually needed because the value would get synced.

This patch doesn't change behavior and just prepares for a future patch
which will use the scroll property tree to look up a LayerImpl's
scroll bounds instead of accessing this through scroll_clip_layer (e.g.,
clip_size in LayerTreeImpl::UpdateScrollbars).

BUG=723263
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2897703002
Cr-Commit-Position: refs/heads/master@{#473320}
Committed:
https://chromium.googlesource.com/chromium/src/+/bf7130daaa2be71bdf491a8ae096...
==========

[commit-bot: I haz the power, 2017-05-19 21:19:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bf7130daaa2be71bdf491a8ae096...