Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: cc/trees/layer_tree_impl.cc

Issue 2897703002: DCHECK that property tree access is safe in LayerTreeImpl::DidUpdateScrollState (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/test/push_properties_counting_layer_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_impl.cc
diff --git a/cc/trees/layer_tree_impl.cc b/cc/trees/layer_tree_impl.cc
index 175c9a4f49f218506549699fdcf7e447153ab0aa..7f2d7994f404ae1991f618bd5c173bdc00849487 100644
--- a/cc/trees/layer_tree_impl.cc
+++ b/cc/trees/layer_tree_impl.cc
@@ -207,6 +207,8 @@ void LayerTreeImpl::DidUpdateScrollState(int layer_id) {
if (!IsActiveTree())
return;
+ DCHECK(lifecycle().AllowsPropertyTreeAccess());
+
// The scroll_clip_layer Layer properties should be up-to-date.
// TODO(pdr): This DCHECK fails on existing tests but should be enabled.
// DCHECK(lifecycle().AllowsLayerPropertyAccess());
« no previous file with comments | « cc/test/push_properties_counting_layer_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698