Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2897633002:
Remove SetSelectedRange from ExpandSelectionToGranularity() (Closed)
DescriptionRemove SetSelectedRange from ExpandSelectionToGranularity()
This CL removes SetSelectedRange from ExpandSelectionToGranularity
and instead uses FrameSelection::SetSelection.
This is done to get rid of FrameSelection::SetSelectedRange().
BUG=721190
Review-Url: https://codereview.chromium.org/2897633002
Cr-Commit-Position: refs/heads/master@{#473815}
Committed: https://chromium.googlesource.com/chromium/src/+/86e3ba6c7d166370ed1c3516216a5e4075077d17
Patch Set 1 #
Total comments: 4
Patch Set 2 : updated #Messages
Total messages: 17 (10 generated)
Description was changed from ========== Remove SetSelectedRange from ExpandSelectionToGranularity() This CL removes SetSelectedRange from ExpandSelectionToGranularity and instead uses FrameSelection::SetSelection. This is done to get Rid of FrameSelection::SetSelectedRange(). BUG=721190 ========== to ========== Remove SetSelectedRange from ExpandSelectionToGranularity() This CL removes SetSelectedRange from ExpandSelectionToGranularity and instead uses FrameSelection::SetSelection. This is done to get rid of FrameSelection::SetSelectedRange(). BUG=721190 ==========
tanvir.rizvi@samsung.com changed reviewers: + shanmuga.m@samsung.com, srirama.m@samsung.com
peer review is fine
tanvir.rizvi@samsung.com changed reviewers: + yosin@chromium.org
@Yosin, I have break this patch into small patch. PTAL!! If i correctly understood the bug. Thanks!
The CQ bit was checked by yosin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2897633002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (right): https://codereview.chromium.org/2897633002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:413: .SetAffinity(VP_DEFAULT_AFFINITY) nit: We don't need to call |SetAffinity(VP_DEFAULT_AFFINITY)|. Since |new_range| is range == non-collapsed range. Selection doesn't use affinity for range selection. https://codereview.chromium.org/2897633002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:414: .SetIsDirectional(false) nit: No need to call |SetIsDirectional()|. The default value is false.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Updated Patch. PTAL https://codereview.chromium.org/2897633002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp (right): https://codereview.chromium.org/2897633002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:413: .SetAffinity(VP_DEFAULT_AFFINITY) On 2017/05/22 04:59:44, yosin_UTC9 wrote: > nit: We don't need to call |SetAffinity(VP_DEFAULT_AFFINITY)|. > Since |new_range| is range == non-collapsed range. > Selection doesn't use affinity for range selection. Done. https://codereview.chromium.org/2897633002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp:414: .SetIsDirectional(false) On 2017/05/22 04:59:43, yosin_UTC9 wrote: > nit: No need to call |SetIsDirectional()|. The default value is false. Done.
The CQ bit was checked by yosin@chromium.org
lgtm
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495502234613790,
"parent_rev": "f15f52293342a5d3dfa6fd3be727b2058711c2d3", "commit_rev":
"86e3ba6c7d166370ed1c3516216a5e4075077d17"}
Message was sent while issue was closed.
Description was changed from ========== Remove SetSelectedRange from ExpandSelectionToGranularity() This CL removes SetSelectedRange from ExpandSelectionToGranularity and instead uses FrameSelection::SetSelection. This is done to get rid of FrameSelection::SetSelectedRange(). BUG=721190 ========== to ========== Remove SetSelectedRange from ExpandSelectionToGranularity() This CL removes SetSelectedRange from ExpandSelectionToGranularity and instead uses FrameSelection::SetSelection. This is done to get rid of FrameSelection::SetSelectedRange(). BUG=721190 Review-Url: https://codereview.chromium.org/2897633002 Cr-Commit-Position: refs/heads/master@{#473815} Committed: https://chromium.googlesource.com/chromium/src/+/86e3ba6c7d166370ed1c3516216a... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/86e3ba6c7d166370ed1c3516216a... |
