Remove SetSelectedRange from ExpandSelectionToGranularity()

third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

 /*
  * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2009 Igalia S.L.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 390 matching lines @@
                             frame.Selection()
                                 .ComputeVisibleSelectionInDOMTreeDeprecated()
                                 .Extent())
           .SetGranularity(granularity)
           .Build());
   const EphemeralRange new_range = selection.ToNormalizedEphemeralRange();
   if (new_range.IsNull())
     return false;
   if (new_range.IsCollapsed())
     return false;
-  TextAffinity affinity = frame.Selection().GetSelectionInDOMTree().Affinity();
-  frame.Selection().SetSelectedRange(new_range, affinity,
-                                     SelectionDirectionalMode::kNonDirectional,
-                                     FrameSelection::kCloseTyping);
+  frame.Selection().SetSelection(SelectionInDOMTree::Builder()
+                                     .SetBaseAndExtent(new_range)
+                                     .SetAffinity(VP_DEFAULT_AFFINITY)

[yosin_UTC9, 2017/05/22 04:59:44]

nit: We don't need to call |SetAffinity(VP_DEFAULT_AFFINITY)|.
Since |new_range| is range == non-collapsed range. 
Selection doesn't use affinity for range selection.

[tanvir, 2017/05/22 12:29:46]

Done.

+                                     .SetIsDirectional(false)

[yosin_UTC9, 2017/05/22 04:59:43]

nit: No need to call |SetIsDirectional()|. The default value is false.

[tanvir, 2017/05/22 12:29:46]

Done.

+                                     .Build(),
+                                 FrameSelection::kCloseTyping);
   return true;
 }
 
 static bool HasChildTags(Element& element, const QualifiedName& tag_name) {
   return !element.getElementsByTagName(tag_name.LocalName())->IsEmpty();
 }
 
 static TriState SelectionListState(const FrameSelection& selection,
                                    const QualifiedName& tag_name) {
   if (selection.ComputeVisibleSelectionInDOMTreeDeprecated().IsCaret()) {
@@ skipping 2603 matching lines @@
           *frame_, kDirectionBackward, kWordGranularity);
     case WebEditingCommandType::kDeleteWordForward:
       return RangesFromCurrentSelectionOrExtendCaret(*frame_, kDirectionForward,
                                                      kWordGranularity);
     default:
       return TargetRangesForInputEvent(*target);
   }
 }
 
 }  // namespace blink