Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2897523004: Tab.NewTabOnload.Local histogram: Add split into Google/Other (Closed)

Created:
6 months ago by Marc Treib
Modified:
6 months ago
Reviewers:
rkaplow, sfiera
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, asvitkine+watch_chromium.org, jered+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Tab.NewTabOnload.Local histogram: Add split into Google/Other With various changes coming to the Google local NTP, it'll be useful to be able to differentiate it from the non-Google local NTP. (Also, take over ownership of the histogram from people who don't work in this area anymore.) BUG=583292 Review-Url: https://codereview.chromium.org/2897523004 Cr-Commit-Position: refs/heads/master@{#473389} Committed: https://chromium.googlesource.com/chromium/src/+/d2867779401995106d046e3c7b0c926a9aa6b3e2

Patch Set 1 #

Patch Set 2 : update histogram description #

Messages

Total messages: 18 (10 generated)
Marc Treib
PTAL!
6 months ago (2017-05-19 12:13:51 UTC) #4
Marc Treib
+rkaplow for histograms.xml, PTAL! If this looks good to both of you, please hit "Commit" ...
6 months ago (2017-05-19 13:23:27 UTC) #7
sfiera
LGTM
6 months ago (2017-05-19 13:31:22 UTC) #8
rkaplow
lgtm
6 months ago (2017-05-19 20:20:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897523004/20001
6 months ago (2017-05-19 20:21:38 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/460347)
6 months ago (2017-05-19 22:18:10 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897523004/20001
6 months ago (2017-05-19 22:24:05 UTC) #15
commit-bot: I haz the power
6 months ago (2017-05-20 00:01:34 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d2867779401995106d046e3c7b0c...

Powered by Google App Engine
This is Rietveld efc10ee0f