Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: chrome/browser/ui/search/search_tab_helper.cc

Issue 2897523004: Tab.NewTabOnload.Local histogram: Add split into Google/Other (Closed)
Patch Set: update histogram description Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/search_tab_helper.cc
diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc
index 444524f48db60fb8d77653071734af1f49be15e4..dec3635410f534c5926a95b7a2b4da3a23e5f90f 100644
--- a/chrome/browser/ui/search/search_tab_helper.cc
+++ b/chrome/browser/ui/search/search_tab_helper.cc
@@ -93,17 +93,22 @@ void RecordNewTabLoadTime(content::WebContents* contents) {
base::TimeDelta duration =
base::TimeTicks::Now() - core_tab_helper->new_tab_start_time();
+ bool is_google = google_util::IsGoogleDomainUrl(
+ contents->GetController().GetLastCommittedEntry()->GetURL(),
+ google_util::ALLOW_SUBDOMAIN, google_util::DISALLOW_NON_STANDARD_PORTS);
if (IsCacheableNTP(contents)) {
- if (google_util::IsGoogleDomainUrl(
- contents->GetController().GetLastCommittedEntry()->GetURL(),
- google_util::ALLOW_SUBDOMAIN,
- google_util::DISALLOW_NON_STANDARD_PORTS)) {
+ if (is_google) {
UMA_HISTOGRAM_TIMES("Tab.NewTabOnload.Google", duration);
} else {
UMA_HISTOGRAM_TIMES("Tab.NewTabOnload.Other", duration);
}
} else {
UMA_HISTOGRAM_TIMES("Tab.NewTabOnload.Local", duration);
+ if (is_google) {
+ UMA_HISTOGRAM_TIMES("Tab.NewTabOnload.LocalGoogle", duration);
+ } else {
+ UMA_HISTOGRAM_TIMES("Tab.NewTabOnload.LocalOther", duration);
+ }
}
core_tab_helper->set_new_tab_start_time(base::TimeTicks());
}
« no previous file with comments | « no previous file | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698