Eliminate remaining ../ header includes

Eliminate remaining ../ header includes

I previously changed all the header includes in third_party/WebKit/public/web
that started with "../" to no longer use relative paths because include paths of
this pattern can include headers that aren't actually specified as build
dependencies (and also, engineers adding new includes of this form can run into
lint errors in some cases). aelias@ pointed out on crbug/724264 that there are
only a small number of these relative include paths in other directories
(ignoring other repos that get pulled in). This CL fixes these remaining
includes.


BUG=724264
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2897503002
Cr-Commit-Position: refs/heads/master@{#473741}
Committed: https://chromium.googlesource.com/chromium/src/+/764476c65b8205086820a5ea02c10a645d6a0518

[rlanday, 2017-05-18 23:52:23]

Description was changed from

==========
Eliminate remaining ../ header includes

BUG=724264
==========

to

==========
Eliminate remaining ../ header includes

BUG=724264
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[rlanday, 2017-05-18 23:52:26]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 23:54:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 00:13:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 00:13:01]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[rlanday, 2017-05-19 00:47:59]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 00:50:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 00:56:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 00:56:07]

Dry run: Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[rlanday, 2017-05-19 01:12:59]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 01:14:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 01:19:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 01:19:58]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_optional_gpu_tests_rel on master.tryserver.chromium.android
(JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_opti...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[rlanday, 2017-05-19 21:57:29]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 21:58:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 22:36:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 22:36:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rlanday, 2017-05-19 23:48:33]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 23:49:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-05-20 01:43:14]

Description was changed from

==========
Eliminate remaining ../ header includes

BUG=724264
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Eliminate remaining ../ header includes

I previously changed all the header includes in third_party/WebKit/public/web
that started with "../" to no longer use relative paths because include paths of
this pattern can include headers that aren't actually specified as build
dependencies (and also, engineers adding new includes of this form can run into
lint errors in some cases). aelias@ pointed out on crbug/724264 that there are
only a small number of these relative include paths in other directories
(ignoring other repos that get pulled in). This CL fixes these remaining
includes.


BUG=724264
==========

[rlanday, 2017-05-20 01:43:15]

rlanday@chromium.org changed reviewers:
+ jochen@chromium.org

[commit-bot: I haz the power, 2017-05-20 03:36:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-20 03:36:34]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[jochen (gone - plz use gerrit), 2017-05-22 11:45:28]

lgtm

https://codereview.chromium.org/2897503002/diff/60001/chrome/browser/BUILD.gn
File chrome/browser/BUILD.gn (right):

https://codereview.chromium.org/2897503002/diff/60001/chrome/browser/BUILD.gn...
chrome/browser/BUILD.gn:4716: deps += [
"//third_party/WebKit/public:blink_headers" ]
it seems this is no longer needed now?

[rlanday, 2017-05-22 18:52:09]

On 2017/05/22 at 11:45:28, jochen wrote:
> lgtm
> 
> https://codereview.chromium.org/2897503002/diff/60001/chrome/browser/BUILD.gn
> File chrome/browser/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2897503002/diff/60001/chrome/browser/BUILD.gn...
> chrome/browser/BUILD.gn:4716: deps += [
"//third_party/WebKit/public:blink_headers" ]
> it seems this is no longer needed now?

I'm going to double-check that this isn't a mistake and it's actually needed for
non-Android platforms too, and then remove the one we don't need

[rlanday, 2017-05-22 18:53:20]

Description was changed from

==========
Eliminate remaining ../ header includes

I previously changed all the header includes in third_party/WebKit/public/web
that started with "../" to no longer use relative paths because include paths of
this pattern can include headers that aren't actually specified as build
dependencies (and also, engineers adding new includes of this form can run into
lint errors in some cases). aelias@ pointed out on crbug/724264 that there are
only a small number of these relative include paths in other directories
(ignoring other repos that get pulled in). This CL fixes these remaining
includes.


BUG=724264
==========

to

==========
Eliminate remaining ../ header includes

I previously changed all the header includes in third_party/WebKit/public/web
that started with "../" to no longer use relative paths because include paths of
this pattern can include headers that aren't actually specified as build
dependencies (and also, engineers adding new includes of this form can run into
lint errors in some cases). aelias@ pointed out on crbug/724264 that there are
only a small number of these relative include paths in other directories
(ignoring other repos that get pulled in). This CL fixes these remaining
includes.


BUG=724264
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[rlanday, 2017-05-22 18:53:24]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 18:54:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 20:34:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 20:34:55]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[rlanday, 2017-05-22 20:42:54]

On 2017/05/22 at 18:52:09, rlanday wrote:
> On 2017/05/22 at 11:45:28, jochen wrote:
> > lgtm
> > 
> >
https://codereview.chromium.org/2897503002/diff/60001/chrome/browser/BUILD.gn
> > File chrome/browser/BUILD.gn (right):
> > 
> >
https://codereview.chromium.org/2897503002/diff/60001/chrome/browser/BUILD.gn...
> > chrome/browser/BUILD.gn:4716: deps += [
"//third_party/WebKit/public:blink_headers" ]
> > it seems this is no longer needed now?
> 
> I'm going to double-check that this isn't a mistake and it's actually needed
for non-Android platforms too, and then remove the one we don't need

Ah I see, I was trying to add it to fix an Android build, so I think your
proposed change is correct

[rlanday, 2017-05-22 20:47:24]

The CQ bit was checked by rlanday@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 20:47:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rlanday, 2017-05-22 23:20:37]

The CQ bit was unchecked by rlanday@chromium.org

[rlanday, 2017-05-22 23:20:39]

The CQ bit was checked by rlanday@chromium.org

[rlanday, 2017-05-22 23:20:39]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2897503002/#ps100001
(title: "Make proposed change")

[commit-bot: I haz the power, 2017-05-22 23:20:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-22 23:28:02]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495495239154570,
"parent_rev": "8aa3fbb79e39ccdf515719286db9b5cca258bc1b", "commit_rev":
"764476c65b8205086820a5ea02c10a645d6a0518"}

[commit-bot: I haz the power, 2017-05-22 23:28:10]

Description was changed from

==========
Eliminate remaining ../ header includes

I previously changed all the header includes in third_party/WebKit/public/web
that started with "../" to no longer use relative paths because include paths of
this pattern can include headers that aren't actually specified as build
dependencies (and also, engineers adding new includes of this form can run into
lint errors in some cases). aelias@ pointed out on crbug/724264 that there are
only a small number of these relative include paths in other directories
(ignoring other repos that get pulled in). This CL fixes these remaining
includes.


BUG=724264
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Eliminate remaining ../ header includes

I previously changed all the header includes in third_party/WebKit/public/web
that started with "../" to no longer use relative paths because include paths of
this pattern can include headers that aren't actually specified as build
dependencies (and also, engineers adding new includes of this form can run into
lint errors in some cases). aelias@ pointed out on crbug/724264 that there are
only a small number of these relative include paths in other directories
(ignoring other repos that get pulled in). This CL fixes these remaining
includes.


BUG=724264
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2897503002
Cr-Commit-Position: refs/heads/master@{#473741}
Committed:
https://chromium.googlesource.com/chromium/src/+/764476c65b8205086820a5ea02c1...
==========

[commit-bot: I haz the power, 2017-05-22 23:28:12]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/764476c65b8205086820a5ea02c1...