Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 2897333002: [ios] Change WebStateList serialization method to use SessionWindowIOS. (Closed)

Created:
3 years, 7 months ago by kkhorimoto
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[ios] Change WebStateList serialization method to use SessionWindowIOS. In order to properly save and restore the application state in the new architecture, (partially) move the implementation outside of TabModel (which is not used in the new architecture). BUG=710848, 723665 NOTRY=true NOPRESUBMIT=true TBR=sdefresne@chromium.org Review-Url: https://codereview.chromium.org/2808773004 Cr-Original-Commit-Position: refs/heads/master@{#465969} Review-Url: https://codereview.chromium.org/2897333002 Cr-Commit-Position: refs/branch-heads/3071@{#686} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/da2e896aee0b0b634c064cb3ad2ed4d71a38349e

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -43 lines) Patch
M ios/chrome/browser/browsing_data/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M ios/chrome/browser/crash_report/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M ios/chrome/browser/sessions/BUILD.gn View 1 4 chunks +19 lines, -7 lines 0 comments Download
M ios/chrome/browser/sessions/NSCoder+Compatibility.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/sessions/session_util.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/tabs/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model.mm View 1 3 chunks +8 lines, -19 lines 0 comments Download
M ios/chrome/browser/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/main/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/web_state_list/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/web_state_list/web_state_list_serialization.h View 2 chunks +5 lines, -5 lines 0 comments Download
M ios/chrome/browser/web_state_list/web_state_list_serialization.mm View 3 chunks +20 lines, -5 lines 0 comments Download
M ios/chrome/browser/web_state_list/web_state_list_serialization_unittest.mm View 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2897333002/20001
3 years, 7 months ago (2017-05-24 21:01:02 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-24 21:03:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/da2e896aee0b0b634c064cb3ad2e...

Powered by Google App Engine
This is Rietveld 408576698