[ios] Change WebStateList serialization method to use SessionWindowIOS.

[ios] Change WebStateList serialization method to use SessionWindowIOS.

In order to properly save and restore the application state in the new
architecture, (partially) move the implementation outside of TabModel
(which is not used in the new architecture).

BUG=710848
Review-Url: https://codereview.chromium.org/2808773004
Cr-Commit-Position: refs/heads/master@{#465969}
Committed: https://chromium.googlesource.com/chromium/src/+/68f546a315406dfa72656a6bd2a6d73ff4269ec2

[sdefresne, 2017-04-11 08:28:46]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2017-04-11 08:28:54]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-11 08:29:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-04-11 08:29:26]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2017-04-11 08:29:27]

Please take a look.

[commit-bot: I haz the power, 2017-04-11 08:38:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 08:38:11]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[sdefresne, 2017-04-11 08:40:36]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 08:40:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-04-11 08:51:08]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-11 08:51:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 10:51:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 10:51:51]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[rohitrao (ping after 24h), 2017-04-12 12:22:10]

lgtm

Why is this change necessary or useful?  Could you add an explanation either to
a bug or the CL description?

Should we create a bug that contains the overall step-by-step plan, so that we
have the process documented somewhere?  I know that all of these CLs are working
towards an end goal, but I can never remember what that goal is or how any
individual CL fits in.

[sdefresne, 2017-04-12 13:58:30]

Description was changed from

==========
[ios] Change WebStateList serialization method to use SessionWindowIOS.

BUG=None
==========

to

==========
[ios] Change WebStateList serialization method to use SessionWindowIOS.

In order to properly save and restore the application state in the new
architecture, (partially) move the implementation outside of TabModel
(which is not used in the new architecture).

BUG=710848
==========

[sdefresne, 2017-04-12 13:58:54]

Thank you for the review.

I've created a tracking bug and updated the description to explain why this
change is necessary.

[sdefresne, 2017-04-12 14:43:20]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 14:43:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-12 17:01:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 17:01:53]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-04-20 09:38:14]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2017-04-20 09:38:29]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-04-20 09:38:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2808773004/#ps100001
(title: "Rename //ios/chrome/browser/sessions:session_window_ios target.")

[commit-bot: I haz the power, 2017-04-20 09:38:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 10:54:06]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1492681109742840,
"parent_rev": "574e8f5fbbe183f725118296fce37ed70cee8cfd", "commit_rev":
"68f546a315406dfa72656a6bd2a6d73ff4269ec2"}

[commit-bot: I haz the power, 2017-04-20 10:54:13]

Description was changed from

==========
[ios] Change WebStateList serialization method to use SessionWindowIOS.

In order to properly save and restore the application state in the new
architecture, (partially) move the implementation outside of TabModel
(which is not used in the new architecture).

BUG=710848
==========

to

==========
[ios] Change WebStateList serialization method to use SessionWindowIOS.

In order to properly save and restore the application state in the new
architecture, (partially) move the implementation outside of TabModel
(which is not used in the new architecture).

BUG=710848

Review-Url: https://codereview.chromium.org/2808773004
Cr-Commit-Position: refs/heads/master@{#465969}
Committed:
https://chromium.googlesource.com/chromium/src/+/68f546a315406dfa72656a6bd2a6...
==========

[commit-bot: I haz the power, 2017-04-20 10:54:14]

Committed patchset #5 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/68f546a315406dfa72656a6bd2a6...