Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/expat/BUILD.gn

Issue 2897283002: Pass -Oz flag to Clang when targeting Android. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/expat/BUILD.gn
diff --git a/third_party/expat/BUILD.gn b/third_party/expat/BUILD.gn
index a2c2d0c637c6d8a248204551c346ad2de4f4c005..1ae296d66003facfe504a667b2eb398ddb173465 100644
--- a/third_party/expat/BUILD.gn
+++ b/third_party/expat/BUILD.gn
@@ -33,6 +33,11 @@ if (is_linux && !is_chromecast && !use_libfuzzer && !use_afl) {
public_configs = [ ":expat_config" ]
+ # TODO(thakis): Remove this once clang no longer crashes when building
+ # libexpat with -Oz.
Nico 2017/05/24 15:33:35 (I checked that this no longer happens with trunk
+ configs -= [ "//build/config/compiler:default_optimization" ]
+ configs += [ "//build/config/compiler:optimize_max" ]
+
defines = [ "_LIB" ]
if (is_win) {
defines += [ "COMPILED_FROM_DSP" ]
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698