Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
3 years, 7 months ago by jkrems Modified:
3 years, 6 months ago Reviewers:
jochen (gone - plz use gerrit), gsathya CC:
v8-reviews_googlegroups.com Target Ref:
refs/heads/master Project:
v8 Visibility:
Public. |
Description[api] Expose Isolate::SetHostImportModuleDynamicallyCallback
This allows embedders to delay initialization of the module system until after
the isolate was created.
BUG=v8:6428
R=gsathya@chromium.org
Review-Url: https://codereview.chromium.org/2897103002
Cr-Commit-Position: refs/heads/master@{#45546}
Committed: https://chromium.googlesource.com/v8/v8/+/a2cbab1bf4ade784e1ee9cf4407b5f6f2223b59c
Patch Set 1 #Patch Set 2 : [api] Remove dynamic import callback from isolate create params #Patch Set 3 : Rebase on master to resolve conflict #
Total comments: 1
Created: 3 years, 7 months ago
Messages
Total messages: 21 (11 generated)
First time contributing. Signed the Google Individual CLA on May 22.
gsathya@chromium.org changed reviewers: + jochen@chromium.org
Thanks for the patch! Can you please remove the option from create_params as well? There's no need to have two different APIs for the same thing. You will have to update d8.cc as well to use this new API.
On 2017/05/24 07:31:58, gsathya wrote: > Thanks for the patch! > > Can you please remove the option from create_params as well? There's no need to > have two different APIs for the same thing. You will have to update d8.cc as > well to use this new API. That makes sense. Updated the create params & d8. Verified locally using `tools/run-tests.py --arch=x64 mjsunit` (which as far as I can tell uses the dynamic import implementation in d8).
The CQ bit was checked by gsathya@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Perfect, thanks! LGTM Please wait for lgtm from jochen as well
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by gsathya@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...) v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...) v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/23106) v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/41862)
Rebased on master so it lands cleanly (only conflict was a blank line). https://codereview.chromium.org/2897103002/diff/40001/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/2897103002/diff/40001/src/d8.cc#newcode3120 src/d8.cc:3120: This new-line is the only change from before - it was added on master which caused a conflict.
The CQ bit was checked by gsathya@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org, gsathya@chromium.org Link to the patchset: https://codereview.chromium.org/2897103002/#ps40001 (title: "Rebase on master to resolve conflict")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495870243904890,
"parent_rev": "c05ca9d7b8ef74d73959a3d582c26dbdbf5f0c7e", "commit_rev":
"a2cbab1bf4ade784e1ee9cf4407b5f6f2223b59c"}
Message was sent while issue was closed.
Description was changed from ========== [api] Expose Isolate::SetHostImportModuleDynamicallyCallback This allows embedders to delay initialization of the module system until after the isolate was created. BUG=v8:6428 R=gsathya@chromium.org ========== to ========== [api] Expose Isolate::SetHostImportModuleDynamicallyCallback This allows embedders to delay initialization of the module system until after the isolate was created. BUG=v8:6428 R=gsathya@chromium.org Review-Url: https://codereview.chromium.org/2897103002 Cr-Commit-Position: refs/heads/master@{#45546} Committed: https://chromium.googlesource.com/v8/v8/+/a2cbab1bf4ade784e1ee9cf4407b5f6f222... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/a2cbab1bf4ade784e1ee9cf4407b5f6f222... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
