[api] Expose Isolate::SetHostImportModuleDynamicallyCallback

[api] Expose Isolate::SetHostImportModuleDynamicallyCallback

This allows embedders to delay initialization of the module system until after
the isolate was created.

BUG=v8:6428
R=gsathya@chromium.org

Review-Url: https://codereview.chromium.org/2897103002
Cr-Commit-Position: refs/heads/master@{#45546}
Committed: https://chromium.googlesource.com/v8/v8/+/a2cbab1bf4ade784e1ee9cf4407b5f6f2223b59c

[jkrems, 2017-05-23 17:55:41]

First time contributing. Signed the Google Individual CLA on May 22.

[gsathya, 2017-05-24 07:31:58]

gsathya@chromium.org changed reviewers:
+ jochen@chromium.org

[gsathya, 2017-05-24 07:31:58]

Thanks for the patch!

Can you please remove the option from create_params as well? There's no need to
have two different APIs for the same thing. You will have to update d8.cc as
well to use this new API.

[jkrems, 2017-05-24 15:38:37]

On 2017/05/24 07:31:58, gsathya wrote:
> Thanks for the patch!
> 
> Can you please remove the option from create_params as well? There's no need
to
> have two different APIs for the same thing. You will have to update d8.cc as
> well to use this new API.

That makes sense. Updated the create params & d8. Verified locally using
`tools/run-tests.py --arch=x64 mjsunit` (which as far as I can tell uses the
dynamic import implementation in d8).

[gsathya, 2017-05-25 03:00:44]

The CQ bit was checked by gsathya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 03:00:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gsathya, 2017-05-25 03:01:32]

Perfect, thanks! LGTM

Please wait for lgtm from jochen as well

[commit-bot: I haz the power, 2017-05-25 03:33:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-25 03:33:36]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-05-26 11:42:48]

lgtm

[gsathya, 2017-05-26 11:45:41]

The CQ bit was checked by gsathya@chromium.org

[commit-bot: I haz the power, 2017-05-26 11:45:50]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 11:46:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 11:47:00]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/23106)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/41862)

[jkrems, 2017-05-26 15:55:31]

Rebased on master so it lands cleanly (only conflict was a blank line).

https://codereview.chromium.org/2897103002/diff/40001/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/2897103002/diff/40001/src/d8.cc#newcode3120
src/d8.cc:3120: 
This new-line is the only change from before - it was added on master which
caused a conflict.

[gsathya, 2017-05-27 07:30:43]

The CQ bit was checked by gsathya@chromium.org

[gsathya, 2017-05-27 07:30:44]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org,
gsathya@chromium.org
Link to the patchset: https://codereview.chromium.org/2897103002/#ps40001
(title: "Rebase on master to resolve conflict")

[commit-bot: I haz the power, 2017-05-27 07:30:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-27 08:02:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495870243904890,
"parent_rev": "c05ca9d7b8ef74d73959a3d582c26dbdbf5f0c7e", "commit_rev":
"a2cbab1bf4ade784e1ee9cf4407b5f6f2223b59c"}

[commit-bot: I haz the power, 2017-05-27 08:02:47]

Description was changed from

==========
[api] Expose Isolate::SetHostImportModuleDynamicallyCallback

This allows embedders to delay initialization of the module system until after
the isolate was created.

BUG=v8:6428
R=gsathya@chromium.org
==========

to

==========
[api] Expose Isolate::SetHostImportModuleDynamicallyCallback

This allows embedders to delay initialization of the module system until after
the isolate was created.

BUG=v8:6428
R=gsathya@chromium.org

Review-Url: https://codereview.chromium.org/2897103002
Cr-Commit-Position: refs/heads/master@{#45546}
Committed:
https://chromium.googlesource.com/v8/v8/+/a2cbab1bf4ade784e1ee9cf4407b5f6f222...
==========

[commit-bot: I haz the power, 2017-05-27 08:02:48]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/a2cbab1bf4ade784e1ee9cf4407b5f6f222...