Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: include/v8.h

Issue 2897103002: [api] Expose Isolate::SetHostImportModuleDynamicallyCallback (Closed)
Patch Set: Rebase on master to resolve conflict Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/d8.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index 72d8c5d4878ef95be341c71990b7ed20072aff62..698c5950a4e3d947521ae9b2b5da6358deee6877 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -6620,8 +6620,7 @@ class V8_EXPORT Isolate {
add_histogram_sample_callback(nullptr),
array_buffer_allocator(nullptr),
external_references(nullptr),
- allow_atomics_wait(true),
- host_import_module_dynamically_callback_(nullptr) {}
+ allow_atomics_wait(true) {}
/**
* The optional entry_hook allows the host application to provide the
@@ -6684,16 +6683,6 @@ class V8_EXPORT Isolate {
* this isolate. This can also be configured via SetAllowAtomicsWait.
*/
bool allow_atomics_wait;
-
- /**
- * This is an unfinished experimental feature, and is only exposed
- * here for internal testing purposes. DO NOT USE.
- *
- * This specifies the callback called by the upcoming dynamic
- * import() language feature to load modules.
- */
- HostImportModuleDynamicallyCallback
- host_import_module_dynamically_callback_;
};
@@ -6885,6 +6874,16 @@ class V8_EXPORT Isolate {
AbortOnUncaughtExceptionCallback callback);
/**
+ * This is an unfinished experimental feature, and is only exposed
+ * here for internal testing purposes. DO NOT USE.
+ *
+ * This specifies the callback called by the upcoming dynamic
+ * import() language feature to load modules.
+ */
+ void SetHostImportModuleDynamicallyCallback(
+ HostImportModuleDynamicallyCallback callback);
+
+ /**
* Optional notification that the system is running low on memory.
* V8 uses these notifications to guide heuristics.
* It is allowed to call this function from another thread while
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/d8.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698