Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1009)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-basics.html

Issue 2897083002: [credentialsmanager] Remove redundant tests (Closed)
Patch Set: Update expectations files Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-basics.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-basics.html b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-basics.html
index 8662ab307661a3befa7da24a98a866c9987b9a27..eb65c38512c1c038768b1b4a1daffba759848f70 100644
--- a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-basics.html
+++ b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-basics.html
@@ -2,12 +2,20 @@
<title>Credential Manager: CredentialsContainer basics.</title>
<script src="../resources/testharness.js"></script>
<script src="../resources/testharnessreport.js"></script>
-<script src="resources/interfaces.js"></script>
+<script src="/w3c/resources/WebIDLParser.js"></script>
+<script src="/w3c/resources/idlharness.js"></script>
+<script type="text/plain" id="tested">
+[Exposed=Window, SecureContext]
+interface CredentialsContainer {
+ Promise<Credential?> get(optional CredentialRequestOptions options);
+};
+</script>
<script>
-test(function () {
- assert_equals(typeof CredentialsContainer, "function");
- verify_interface('CredentialsContainer', navigator.credentials, {
- 'get': 'function'
- });
-}, 'Interfaces and attributes of CredentialsContainer');
+var idl_array = new IdlArray();
+idl_array.add_idls(document.querySelector('#tested').textContent);
+idl_array.add_objects({
+ Window: ['window'],
+ CredentialsContainer: ['navigator.credentials']
+});
+idl_array.test();
Mike West 2017/05/29 12:10:38 I think we can just delete this test entirely. It
mike3 2017/05/29 17:41:11 Done.
mike3 2017/05/29 18:02:21 Follow-up in WPT: https://github.com/w3c/web-platf
</script>

Powered by Google App Engine
This is Rietveld 408576698