Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html

Issue 2897083002: [credentialsmanager] Remove redundant tests (Closed)
Patch Set: Update expectations files Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
index a27e31784078d6002ebc710a8b2adde6010f42e4..a403eb554021583949c5e2dbd95b47563c1558ea 100644
--- a/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
+++ b/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
@@ -2,7 +2,31 @@
<title>Credential Manager: get() basics.</title>
<script src="../resources/testharness.js"></script>
<script src="../resources/testharnessreport.js"></script>
-<script src="resources/interfaces.js"></script>
+<script src="/w3c/resources/WebIDLParser.js"></script>
+<script src="/w3c/resources/idlharness.js"></script>
+<script type="text/plain" id="tested">
+[Exposed=Window, SecureContext]
+interface Credential {
+ readonly attribute USVString id;
+ readonly attribute DOMString type;
+};
+
+[NoInterfaceObject, SecureContext]
+interface CredentialUserData {
+ readonly attribute USVString name;
+ readonly attribute USVString iconURL;
+};
+
+[Constructor(HTMLFormElement form),
+ Constructor(PasswordCredentialData data),
+ Exposed=Window,
+ SecureContext]
+interface PasswordCredential : Credential {
+ readonly attribute USVString password;
+};
+
+PasswordCredential implements CredentialUserData;
+</script>
<script>
function stubResolverUndefinedChecker(c) {
assert_equals(c, undefined);
@@ -130,11 +154,13 @@ add_completion_callback(() => {
var password = "pencil";
function stubResolverChecker(c) {
- verify_interface('PasswordCredential', c, {
- id: 'string',
- name: 'string',
- iconURL: 'string'
+ var idl_array = new IdlArray();
+ idl_array.add_idls(document.querySelector('#tested').textContent);
+ window.c = c;
+ idl_array.add_objects({
+ PasswordCredential: ["c"]
});
+ idl_array.test();
Mike West 2017/05/29 12:10:38 Likewise, the IDL checks here can just be removed
mike3 2017/05/29 17:41:11 Done.
assert_equals(c.id, id);
assert_equals(c.name, name);

Powered by Google App Engine
This is Rietveld 408576698