third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-basics.html - Issue 2897083002: [credentialsmanager] Remove redundant tests

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-basics.html

Issue 2897083002: [credentialsmanager] Remove redundant tests (Closed)

Patch Set: Update expectations files Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html » ('j') | third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Credential Manager: CredentialsContainer basics.</title>	2 <title>Credential Manager: CredentialsContainer basics.</title>

3 <script src="../resources/testharness.js"></script>	3 <script src="../resources/testharness.js"></script>

4 <script src="../resources/testharnessreport.js"></script>	4 <script src="../resources/testharnessreport.js"></script>

5 <script src="resources/interfaces.js"></script>	5 <script src="/w3c/resources/WebIDLParser.js"></script>

	6 <script src="/w3c/resources/idlharness.js"></script>

	7 <script type="text/plain" id="tested">

	8 [Exposed=Window, SecureContext]

	9 interface CredentialsContainer {

	10 Promise<Credential?> get(optional CredentialRequestOptions options);

	11 };

	12 </script>

6 <script>	13 <script>

7 test(function () {	14 var idl_array = new IdlArray();

8 assert_equals(typeof CredentialsContainer, "function");	15 idl_array.add_idls(document.querySelector('#tested').textContent);

9 verify_interface('CredentialsContainer', navigator.credentials, {	16 idl_array.add_objects({

10 'get': 'function'	17 Window: ['window'],

11 });	18 CredentialsContainer: ['navigator.credentials']

12 }, 'Interfaces and attributes of CredentialsContainer');	19 });

	20 idl_array.test();
	Mike West 2017/05/29 12:10:38 I think we can just delete this test entirely. It I think we can just delete this test entirely. It should be subsumed by https://github.com/w3c/web-platform-tests/blob/master/credential-management/i... (though I note that that test is missing the `[Exposed=Window, SecureContext]` bit from the interface; we should fix that). mike3 2017/05/29 17:41:11 Done. Show quoted text On 2017/05/29 12:10:38, Mike West wrote: > I think we can just delete this test entirely. It should be subsumed by > https://github.com/w3c/web-platform-tests/blob/master/credential-management/i... > (though I note that that test is missing the `[Exposed=Window, SecureContext]` > bit from the interface; we should fix that). Done. mike3 2017/05/29 18:02:21 Follow-up in WPT: https://github.com/w3c/web-platf Show quoted text On 2017/05/29 12:10:38, Mike West wrote: > I think we can just delete this test entirely. It should be subsumed by > https://github.com/w3c/web-platform-tests/blob/master/credential-management/i... > (though I note that that test is missing the `[Exposed=Window, SecureContext]` > bit from the interface; we should fix that). Follow-up in WPT: https://github.com/w3c/web-platform-tests/pull/6076
13 </script>	21 </script>

OLD	NEW