Remove dependency on order of enum EBorderStyle

Remove dependency on order of enum EBorderStyle

This patch removes order dependent checks for EBorderStyle and replaces
them with checks that check that properties aren't equal to a certain
value.

BUG=684966
Review-Url: https://codereview.chromium.org/2896783002
Cr-Commit-Position: refs/heads/master@{#473845}
Committed: https://chromium.googlesource.com/chromium/src/+/5765835a9a242bab20810ad5d60ab504902580f5

[nainar, 2017-05-22 06:22:56]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-22 06:23:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-05-22 06:23:20]

nainar@chromium.org changed reviewers:
+ shend@chromium.org

[nainar, 2017-05-22 06:23:21]

shend@, 

PTAL? Thanks!

[rune, 2017-05-22 07:21:00]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2017-05-22 07:21:01]

In description: isn't it spelled "dependency"?

Could you add a test for the bug you fixed?

[nainar, 2017-05-22 07:23:32]

Description was changed from

==========
Remove dependancy on order of enum EBorderStyle

This patch removes order dependent checks for EBorderStyle and replaces
them with checks that check that properties aren't equal to a certain
value.

This patch also fixes a bug I introduced in a previous patch of mine
here: https://codereview.chromium.org/2890733002, where I replaced
one check with the incorrect value. (See:
https://codereview.chromium.org/2890733002/diff/20001/third_party/WebKit/Sour...)

BUG=684966
==========

to

==========
Remove dependency on order of enum EBorderStyle

This patch removes order dependent checks for EBorderStyle and replaces
them with checks that check that properties aren't equal to a certain
value.

This patch also fixes a bug I introduced in a previous patch of mine
here: https://codereview.chromium.org/2890733002, where I replaced
one check with the incorrect value. (See:
https://codereview.chromium.org/2890733002/diff/20001/third_party/WebKit/Sour...)

BUG=684966
==========

[commit-bot: I haz the power, 2017-05-22 08:25:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-22 08:25:59]

Dry run: This issue passed the CQ dry run.

[nainar, 2017-05-23 05:08:45]

The CQ bit was checked by nainar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-23 05:09:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nainar, 2017-05-23 05:09:12]

Description was changed from

==========
Remove dependency on order of enum EBorderStyle

This patch removes order dependent checks for EBorderStyle and replaces
them with checks that check that properties aren't equal to a certain
value.

This patch also fixes a bug I introduced in a previous patch of mine
here: https://codereview.chromium.org/2890733002, where I replaced
one check with the incorrect value. (See:
https://codereview.chromium.org/2890733002/diff/20001/third_party/WebKit/Sour...)

BUG=684966
==========

to

==========
Remove dependency on order of enum EBorderStyle

This patch removes order dependent checks for EBorderStyle and replaces
them with checks that check that properties aren't equal to a certain
value.

BUG=684966
==========

[nainar, 2017-05-23 05:10:15]

On 2017/05/22 at 07:21:01, rune wrote:
> In description: isn't it spelled "dependency"?
> 
> Could you add a test for the bug you fixed?

Changed the spelling. Also fixing that bug in a parent CL here:
https://codereview.chromium.org/2895933004/. There were unit tests that should
have discovered this bug. And it didn't because of another bug I discovered.
Moved the fixes and added tests to the other CL to stop scope creep.

[shend, 2017-05-23 06:04:55]

lgtm

[nainar, 2017-05-23 07:46:53]

rune@, 

For OWNERS. PTAL? Thanks!

[rune, 2017-05-23 08:14:38]

lgtm

[commit-bot: I haz the power, 2017-05-23 08:49:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 08:49:49]

Dry run: This issue passed the CQ dry run.

[nainar, 2017-05-23 09:01:48]

The CQ bit was checked by nainar@chromium.org

[commit-bot: I haz the power, 2017-05-23 09:02:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 09:15:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-23 09:15:12]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[nainar, 2017-05-23 09:59:29]

The CQ bit was checked by nainar@chromium.org

[commit-bot: I haz the power, 2017-05-23 09:59:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 10:07:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495533569333540,
"parent_rev": "af1c106f452b464753dfc1c4626151b28f8fa1ef", "commit_rev":
"5765835a9a242bab20810ad5d60ab504902580f5"}

[commit-bot: I haz the power, 2017-05-23 10:08:00]

Description was changed from

==========
Remove dependency on order of enum EBorderStyle

This patch removes order dependent checks for EBorderStyle and replaces
them with checks that check that properties aren't equal to a certain
value.

BUG=684966
==========

to

==========
Remove dependency on order of enum EBorderStyle

This patch removes order dependent checks for EBorderStyle and replaces
them with checks that check that properties aren't equal to a certain
value.

BUG=684966

Review-Url: https://codereview.chromium.org/2896783002
Cr-Commit-Position: refs/heads/master@{#473845}
Committed:
https://chromium.googlesource.com/chromium/src/+/5765835a9a242bab20810ad5d60a...
==========

[commit-bot: I haz the power, 2017-05-23 10:08:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5765835a9a242bab20810ad5d60a...