third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp - Issue 2896783002: Remove dependency on order of enum EBorderStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp

Issue 2896783002: Remove dependency on order of enum EBorderStyle (Closed)

Patch Set: Merge branch and make it dependent on https://codereview.chromium.org/2895933004 Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp

index d1e9fbc29a362afc25158ee31c63e16b43233ddd..9d6ea75bfcb7ed5cda0cc04f5bbfe48a62262939 100644

--- a/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp

@@ -568,7 +568,8 @@ bool LayoutMultiColumnSet::ComputeColumnRuleBounds(

EBorderStyle rule_style = block_style.ColumnRuleStyle();

LayoutUnit rule_thickness(block_style.ColumnRuleWidth());

LayoutUnit col_gap = ColumnGap();

- bool render_rule = rule_style > EBorderStyle::kHidden && !rule_transparent;

+ bool render_rule =

+ ComputedStyle::BorderStyleIsVisible(rule_style) && !rule_transparent;

if (!render_rule)

return false;