Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2896723004: Wait for GPU to finish before committing first video overlay frame. (Closed)

Created:
3 years, 7 months ago by jbauman
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Wait for GPU to finish before committing first video overlay frame. The current code to do CopyResource helps in some cases, but with 4k videos it still may flicker black before the first frame. Waiting for the GPU commands to execute before the commit seems to help. BUG=654631 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2892123002 Cr-Original-Commit-Position: refs/heads/master@{#473373} Review-Url: https://codereview.chromium.org/2896723004 . Cr-Commit-Position: refs/branch-heads/3071@{#662} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/2624ec4524a408dafb8d13bb29a777f3bd03bd3d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M gpu/ipc/service/direct_composition_surface_win.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jbauman
3 years, 7 months ago (2017-05-22 22:23:37 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2624ec4524a408dafb8d13bb29a777f3bd03bd3d.

Powered by Google App Engine
This is Rietveld 408576698