Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2892123002: Wait for GPU to finish before committing first video overlay frame. (Closed)

Created:
3 years, 7 months ago by jbauman
Modified:
3 years, 7 months ago
Reviewers:
sunnyps
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Wait for GPU to finish before committing first video overlay frame. The current code to do CopyResource helps in some cases, but with 4k videos it still may flicker black before the first frame. Waiting for the GPU commands to execute before the commit seems to help. BUG=654631 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2892123002 Cr-Commit-Position: refs/heads/master@{#473373} Committed: https://chromium.googlesource.com/chromium/src/+/7b6d8a3148e1279efa7fac40870557a5ca77d7dc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M gpu/ipc/service/direct_composition_surface_win.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jbauman
3 years, 7 months ago (2017-05-19 22:28:54 UTC) #7
sunnyps
lgtm
3 years, 7 months ago (2017-05-19 22:40:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892123002/1
3 years, 7 months ago (2017-05-19 22:45:41 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 22:51:30 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7b6d8a3148e1279efa7fac408705...

Powered by Google App Engine
This is Rietveld 408576698