Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2896703003: [DMC #11] Move some rendered rect method impls from DMC To TextMatchMarkerListImpl (Closed)

Created:
3 years, 7 months ago by rlanday
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move some rendered rect method impls from DMC To TextMatchMarkerListImpl In this CL, I'm moving some rendered rect-related logic for TextMatch markers from DocumentMarkerController into TextMatchMarkerListImpl. I am adding two methods to TextMatchMarkerListImpl: AppendRenderedRectsToVector(const Node&, Vector<IntRect>*) UpdateMarkerRenderedRectIfNeeded(const Node&, RenderedDocumentMarker&) In a later CL, I will move the implementations from DocumentMarkerController.cpp to TextMatchMarkerListImpl.cpp, and make UpdateMarkerRenderedRectIfNeeded a private method of TextMatchMarkerListImpl. BUG=707867 Review-Url: https://codereview.chromium.org/2896703003 Cr-Commit-Position: refs/heads/master@{#474596} Committed: https://chromium.googlesource.com/chromium/src/+/8b8a4e0948600fe3347678918abb63c43e1c2ee3

Patch Set 1 #

Patch Set 2 : Remove DocumentMarkerController::UpdateMarkerRenderedRectIfNeeded() declaration #

Patch Set 3 : Rebase #

Total comments: 8

Patch Set 4 : Modify DCHECK, make Update..IfNeeded private, return vector instead of appending #

Patch Set 5 : Remove unnecessary IsEmpty() check #

Patch Set 6 : Rebase #

Total comments: 2

Patch Set 7 : Remove UpdateMarkerRenderedRectIfNecessary(), add const to RenderedRects() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -20 lines) Patch
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 2 3 4 5 6 3 chunks +22 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/editing/markers/TextMatchMarkerListImpl.h View 1 2 3 4 5 6 2 chunks +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 36 (26 generated)
rlanday
3 years, 7 months ago (2017-05-21 22:22:14 UTC) #4
yosin_UTC9
https://codereview.chromium.org/2896703003/diff/40001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp (right): https://codereview.chromium.org/2896703003/diff/40001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp#newcode411 third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:411: DCHECK(!document_->View() || !document_->View()->NeedsLayout()); We should not call this function ...
3 years, 7 months ago (2017-05-22 05:24:18 UTC) #11
rlanday
https://codereview.chromium.org/2896703003/diff/40001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp (right): https://codereview.chromium.org/2896703003/diff/40001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp#newcode411 third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:411: DCHECK(!document_->View() || !document_->View()->NeedsLayout()); On 2017/05/22 at 05:24:18, yosin_UTC9 wrote: ...
3 years, 7 months ago (2017-05-22 05:29:11 UTC) #12
yosin_UTC9
https://codereview.chromium.org/2896703003/diff/40001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp (right): https://codereview.chromium.org/2896703003/diff/40001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp#newcode411 third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:411: DCHECK(!document_->View() || !document_->View()->NeedsLayout()); On 2017/05/22 at 05:29:11, rlanday wrote: ...
3 years, 7 months ago (2017-05-22 05:54:26 UTC) #13
rlanday
On 2017/05/22 at 05:54:26, yosin wrote: > > > Did you find the case of ...
3 years, 7 months ago (2017-05-22 18:24:33 UTC) #16
yosin_UTC9
https://codereview.chromium.org/2896703003/diff/100001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp File third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp (right): https://codereview.chromium.org/2896703003/diff/100001/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp#newcode449 third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp:449: void TextMatchMarkerListImpl::UpdateMarkerRenderedRectIfNeeded( Since this function is just two lines, ...
3 years, 7 months ago (2017-05-24 09:17:23 UTC) #25
rlanday
Updated
3 years, 7 months ago (2017-05-24 20:24:53 UTC) #27
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-25 05:17:30 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896703003/120001
3 years, 7 months ago (2017-05-25 05:17:43 UTC) #33
commit-bot: I haz the power
3 years, 7 months ago (2017-05-25 07:08:06 UTC) #36
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/8b8a4e0948600fe3347678918abb...

Powered by Google App Engine
This is Rietveld 408576698