Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp

Issue 2896703003: [DMC #11] Move some rendered rect method impls from DMC To TextMatchMarkerListImpl (Closed)
Patch Set: Remove UpdateMarkerRenderedRectIfNecessary(), add const to RenderedRects() Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
index 5e71a42497cf11a979fea3b59ff801262adae7b8..e600ded01547177b7675c048a34b62a7fe884ad0 100644
--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp
@@ -396,7 +396,11 @@ DocumentMarkerVector DocumentMarkerController::Markers() {
}
Vector<IntRect> DocumentMarkerController::RenderedRectsForTextMatchMarkers() {
+ DCHECK(!document_->View()->NeedsLayout());
+ DCHECK(!document_->NeedsLayoutTreeUpdate());
+
Vector<IntRect> result;
+
if (!PossiblyHasMarkers(DocumentMarker::kTextMatch))
return result;
DCHECK(!(markers_.IsEmpty()));
@@ -412,17 +416,26 @@ Vector<IntRect> DocumentMarkerController::RenderedRectsForTextMatchMarkers() {
MarkerLists* markers = node_iterator->value.Get();
DocumentMarkerList* const list =
ListForType(markers, DocumentMarker::kTextMatch);
- if (!list || list->IsEmpty())
+ if (!list)
continue;
+ result.AppendVector(ToTextMatchMarkerListImpl(list)->RenderedRects(node));
+ }
- for (DocumentMarker* marker : list->GetMarkers()) {
- RenderedDocumentMarker* const rendered_marker =
- ToRenderedDocumentMarker(marker);
- UpdateMarkerRenderedRectIfNeeded(node, *rendered_marker);
- if (!rendered_marker->IsRendered())
- continue;
- result.push_back(rendered_marker->RenderedRect());
- }
+ return result;
+}
+
+// TODO(rlanday): move this to TextMatchMarkerListImpl.cpp
+Vector<IntRect> TextMatchMarkerListImpl::RenderedRects(const Node& node) const {
+ Vector<IntRect> result;
+
+ for (DocumentMarker* marker : markers_) {
+ RenderedDocumentMarker* const rendered_marker =
+ ToRenderedDocumentMarker(marker);
+ if (!rendered_marker->IsValid())
+ UpdateMarkerRenderedRect(node, *rendered_marker);
+ if (!rendered_marker->IsRendered())
+ continue;
+ result.push_back(rendered_marker->RenderedRect());
}
return result;
@@ -433,15 +446,6 @@ static void InvalidatePaintForTickmarks(const Node& node) {
frame_view->InvalidatePaintForTickmarks();
}
-void DocumentMarkerController::UpdateMarkerRenderedRectIfNeeded(
- const Node& node,
- RenderedDocumentMarker& marker) {
- DCHECK(!document_->View() || !document_->View()->NeedsLayout());
- DCHECK(!document_->NeedsLayoutTreeUpdate());
- if (!marker.IsValid())
- UpdateMarkerRenderedRect(node, marker);
-}
-
void DocumentMarkerController::InvalidateRectsForTextMatchMarkersInNode(
const Node& node) {
MarkerLists* markers = markers_.at(&node);

Powered by Google App Engine
This is Rietveld 408576698