Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 2896633002: diagnose_bloat.py: add missing GN arg for local Linux builds. (Closed)

Created:
3 years, 7 months ago by estevenson
Modified:
3 years, 7 months ago
Reviewers:
F
CC:
chromium-reviews, wnwen+watch_chromium.org, estevenson+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

diagnose_bloat.py: add missing GN arg for local Linux builds. The following args are required to generate map files that work with //tools/binary_size/supersize on Linux: * is_official_build = true * allow_posix_link_time_opt = false * generate_linker_map = true BUG=723798 Review-Url: https://codereview.chromium.org/2896633002 Cr-Commit-Position: refs/heads/master@{#473921} Committed: https://chromium.googlesource.com/chromium/src/+/a0d07deeaa973b547aab5cc88918bb15432f093d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M tools/binary_size/diagnose_bloat.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
estevenson
ptal Felix!
3 years, 7 months ago (2017-05-19 19:09:46 UTC) #2
F
lgtm
3 years, 7 months ago (2017-05-23 15:36:59 UTC) #3
estevenson
On 2017/05/19 19:09:46, estevenson wrote: > ptal Felix! Thanks!
3 years, 7 months ago (2017-05-23 15:48:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2896633002/1
3 years, 7 months ago (2017-05-23 15:49:47 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 16:04:47 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a0d07deeaa973b547aab5cc88918...

Powered by Google App Engine
This is Rietveld 408576698