tools/binary_size/diagnose_bloat.py - Issue 2896633002: diagnose_bloat.py: add missing GN arg for local Linux builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/binary_size/diagnose_bloat.py

Issue 2896633002: diagnose_bloat.py: add missing GN arg for local Linux builds. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/binary_size/diagnose_bloat.py

diff --git a/tools/binary_size/diagnose_bloat.py b/tools/binary_size/diagnose_bloat.py

index edaeb30ef09cd2568307c61d88f191091e7e4509..0bf0e05a6e6a566a4590dfea9be02ad38c4f3a3d 100755

--- a/tools/binary_size/diagnose_bloat.py

+++ b/tools/binary_size/diagnose_bloat.py

@@ -249,7 +249,8 @@ class _BuildHelper(object):

self.extra_gn_args_str = (' exclude_unwind_tables=true '

'ffmpeg_branding="Chrome" proprietary_codecs=true')

if self.IsLinux():

- self.extra_gn_args_str += ' allow_posix_link_time_opt=false'

+ self.extra_gn_args_str += (

+ ' allow_posix_link_time_opt=false generate_linker_map=true')

self.target = self.target if self.IsAndroid() else 'chrome'

def _GenGnCmd(self):

« no previous file with comments | « no previous file | no next file » | no next file with comments »