Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Unified Diff: ios/web/web_state/web_state_impl_unittest.mm

Issue 2896623003: Added web::NavigationContext::GetPageTransition. (Closed)
Patch Set: Fixed condition for SetIsCreatedFromHashChange call Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/web_state_impl_unittest.mm
diff --git a/ios/web/web_state/web_state_impl_unittest.mm b/ios/web/web_state/web_state_impl_unittest.mm
index 609abe70d09abea97c73d53fbfbfeb429979f1a3..ab10971f3cb6a6157cb8df6c547ee421046a6164 100644
--- a/ios/web/web_state/web_state_impl_unittest.mm
+++ b/ios/web/web_state/web_state_impl_unittest.mm
@@ -351,7 +351,9 @@ TEST_F(WebStateImplTest, ObserverTest) {
ASSERT_FALSE(observer->did_finish_navigation_info());
const GURL url("http://test");
std::unique_ptr<web::NavigationContext> context =
- NavigationContextImpl::CreateNavigationContext(web_state_.get(), url);
+ NavigationContextImpl::CreateNavigationContext(
+ web_state_.get(), url,
+ ui::PageTransition::PAGE_TRANSITION_AUTO_BOOKMARK);
web_state_->OnNavigationFinished(context.get());
ASSERT_TRUE(observer->did_finish_navigation_info());
EXPECT_EQ(web_state_.get(),
@@ -359,6 +361,8 @@ TEST_F(WebStateImplTest, ObserverTest) {
NavigationContext* actual_context =
observer->did_finish_navigation_info()->context.get();
EXPECT_EQ(context->GetUrl(), actual_context->GetUrl());
+ EXPECT_TRUE(PageTransitionTypeIncludingQualifiersIs(
+ context->GetPageTransition(), actual_context->GetPageTransition()));
EXPECT_FALSE(actual_context->IsSameDocument());
EXPECT_FALSE(actual_context->IsErrorPage());
EXPECT_FALSE(actual_context->GetResponseHeaders());
@@ -370,6 +374,8 @@ TEST_F(WebStateImplTest, ObserverTest) {
EXPECT_EQ(web_state_.get(), observer->did_start_navigation_info()->web_state);
actual_context = observer->did_start_navigation_info()->context.get();
EXPECT_EQ(context->GetUrl(), actual_context->GetUrl());
+ EXPECT_TRUE(PageTransitionTypeIncludingQualifiersIs(
+ context->GetPageTransition(), actual_context->GetPageTransition()));
EXPECT_FALSE(actual_context->IsSameDocument());
EXPECT_FALSE(actual_context->IsErrorPage());
EXPECT_FALSE(actual_context->GetResponseHeaders());

Powered by Google App Engine
This is Rietveld 408576698