Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1644)

Unified Diff: ios/web/web_state/web_state_observer_bridge_unittest.mm

Issue 2896623003: Added web::NavigationContext::GetPageTransition. (Closed)
Patch Set: Fixed condition for SetIsCreatedFromHashChange call Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/web_state_observer_bridge_unittest.mm
diff --git a/ios/web/web_state/web_state_observer_bridge_unittest.mm b/ios/web/web_state/web_state_observer_bridge_unittest.mm
index 29d433fe26e56f301e6a29336918e3ff5b4d5745..2f73d8b8af29afa105e7c3b7ee14c1db31ed7075 100644
--- a/ios/web/web_state/web_state_observer_bridge_unittest.mm
+++ b/ios/web/web_state/web_state_observer_bridge_unittest.mm
@@ -44,8 +44,9 @@ TEST_F(WebStateObserverBridgeTest, DidStartNavigation) {
GURL url("https://chromium.test/");
std::unique_ptr<web::NavigationContext> context =
- web::NavigationContextImpl::CreateNavigationContext(&test_web_state_,
- url);
+ web::NavigationContextImpl::CreateNavigationContext(
+ &test_web_state_, url,
+ ui::PageTransition::PAGE_TRANSITION_FORWARD_BACK);
bridge_->DidStartNavigation(context.get());
ASSERT_TRUE([observer_ didStartNavigationInfo]);
@@ -57,6 +58,9 @@ TEST_F(WebStateObserverBridgeTest, DidStartNavigation) {
EXPECT_EQ(context->IsSameDocument(), actual_context->IsSameDocument());
EXPECT_EQ(context->IsErrorPage(), actual_context->IsErrorPage());
EXPECT_EQ(context->GetUrl(), actual_context->GetUrl());
+ EXPECT_TRUE(PageTransitionTypeIncludingQualifiersIs(
+ ui::PageTransition::PAGE_TRANSITION_FORWARD_BACK,
+ actual_context->GetPageTransition()));
EXPECT_EQ(context->GetResponseHeaders(),
actual_context->GetResponseHeaders());
}
@@ -67,8 +71,9 @@ TEST_F(WebStateObserverBridgeTest, DidFinishNavigation) {
GURL url("https://chromium.test/");
std::unique_ptr<web::NavigationContext> context =
- web::NavigationContextImpl::CreateNavigationContext(&test_web_state_,
- url);
+ web::NavigationContextImpl::CreateNavigationContext(
+ &test_web_state_, url,
+ ui::PageTransition::PAGE_TRANSITION_FROM_ADDRESS_BAR);
bridge_->DidFinishNavigation(context.get());
ASSERT_TRUE([observer_ didFinishNavigationInfo]);
@@ -80,6 +85,9 @@ TEST_F(WebStateObserverBridgeTest, DidFinishNavigation) {
EXPECT_EQ(context->IsSameDocument(), actual_context->IsSameDocument());
EXPECT_EQ(context->IsErrorPage(), actual_context->IsErrorPage());
EXPECT_EQ(context->GetUrl(), actual_context->GetUrl());
+ EXPECT_TRUE(PageTransitionTypeIncludingQualifiersIs(
+ ui::PageTransition::PAGE_TRANSITION_FROM_ADDRESS_BAR,
+ actual_context->GetPageTransition()));
EXPECT_EQ(context->GetResponseHeaders(),
actual_context->GetResponseHeaders());
}

Powered by Google App Engine
This is Rietveld 408576698